https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add SMTP settings |Add SMTP configuration | |options to Administration CC| |katrin.fischer@bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107598&action=edit Bug 22343: Add a new table to store SMTP servers configs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107600&action=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107602&action=edit Bug 22343: API routes for SMTP servers CRUD -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107603|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107604&action=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The plan is to use this: https://metacpan.org/pod/Email::Sender::Transport::SMTP so the conversion should be straight-forward. Email::Sender provides the same ::sendmail method we use, we just need to instantiate the transport object based on the effective library config. Almost there! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #13 from Liz Rea <wizzyrea@gmail.com> --- I am 100% for this patch, anything that puts the control in the hands of the libraries and doesn't make linux knowledge a gatekeeping factor in configuring the system is a vast improvement over how it is now. We need this, freedom to the libraries and less-technical users. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #14)

Plus, I think it makes it easier to deploy and scale Koha even for technical users when we have this information in the app database rather than having to mess around with third-party MTA apps and what not (or anything else on the file system).

Well maybe not easier to initially deploy... but easier to later scale and maintain... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #16)

The idea is to allow configuring it so we don't need an SMTP Server running in localhost. Think of a dockered deployment.

That's exactly the scenario I was thinking of heh.

Plus, give flexibility to the end users (non tech)

Very handy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #18)

Is the use of these configuration options optional? Wondering if existing setups will still keep working on update.

If you don't set anything, it defaults to the current localhost:25. It is hardcoded as it is now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #20)

So if nothing is set, the MTA settings will be used. Thx!

Technically, we currently use Mail::Sendmail which has a hardcoded value (localhost, port 25, no auth, no SSL, etc). The plan is to be able to set it, and obviously keep the current behaviour by default. I wouldn't dare to change that :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107599|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107988&action=edit Bug 22343: Add new table schema file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107990&action=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107992&action=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107994&action=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107996&action=edit Bug 22343: Adapt Koha::Illrequest -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107998&action=edit Bug 22343: Adapt runreport.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, this is now complete (i.e. all places that send emails use the new feature). Go test! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108009&action=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108107&action=edit Bug 22343: Add a new table to store SMTP servers configs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108109&action=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108111&action=edit Bug 22343: API routes for SMTP servers CRUD -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108113&action=edit Bug 22343: Add ->transport method This patch adds a Koha::SMTP::Server->transport method that returns an Email::Sender::Transport::SMTP object generated with the current object's settings. Special case is handled for disabled SSL. This is all covered by the introduced tests. 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108115&action=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108117&action=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108119&action=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108107|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108131&action=edit Bug 22343: Add a new table to store SMTP servers configs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108109|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108133&action=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108111|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108135&action=edit Bug 22343: API routes for SMTP servers CRUD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108113|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108137&action=edit Bug 22343: Add ->transport method This patch adds a Koha::SMTP::Server->transport method that returns an Email::Sender::Transport::SMTP object generated with the current object's settings. Special case is handled for disabled SSL. This is all covered by the introduced tests. 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108115|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108139&action=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108117|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108141&action=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108119|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108143&action=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #65 from Father Vlasie <fv@spots.school> --- I just want to say thank you for this much needed feature with especial thanks to Tomás for doing the hard work! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #68 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108529&action=edit Bug 22343: Explicit testing of charset This patch tests content type and charset separatedly. This is done to avoid assuming the underlying library will always return the data structured in the same way, which is not to be guaranteed on the spec. This way the tests don't fail if things are ordered in another way, or if some more attributes are passed in the content type header (respecting the RFC for the format). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108131|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108135|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108143|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #70 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108538&action=edit Bug 22343: Add new table schema file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #72 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108540&action=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108542&action=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108544&action=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108546&action=edit Bug 22343: Adapt Koha::Illrequest Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108548&action=edit Bug 22343: Adapt runreport.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #82 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #67)

Seems like a simple failure to fix, but I'm not sure what the fix should be. Is this a difference in response that will crop up from server differences? Or does it fail on your system as well now?

The test relied too much on a specific way the header was built. It actually highlighted bad design because the tests were showing the charset was being set as 'utf8' regardless. So I tweaked it a little bit so it actually sets the charset, following the design on Email::MIME and Email::Stuffer. No place in the codebase is setting it with this rewrite, though. As we return UTF-8 email body. But worth leaving room for passing it, just in case, in the right way. The tests now check iso-8859-1 is being set if requested. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108638&action=edit Bug 22343: (QA follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108537|0 |1 is obsolete| | Attachment #108538|0 |1 is obsolete| | Attachment #108539|0 |1 is obsolete| | Attachment #108540|0 |1 is obsolete| | Attachment #108541|0 |1 is obsolete| | Attachment #108542|0 |1 is obsolete| | Attachment #108543|0 |1 is obsolete| | Attachment #108544|0 |1 is obsolete| | Attachment #108545|0 |1 is obsolete| | Attachment #108546|0 |1 is obsolete| | Attachment #108547|0 |1 is obsolete| | Attachment #108548|0 |1 is obsolete| | Attachment #108549|0 |1 is obsolete| | Attachment #108609|0 |1 is obsolete| | Attachment #108638|0 |1 is obsolete| | --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108642&action=edit Bug 22343: Add a new table to store SMTP servers configs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108644&action=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108646&action=edit Bug 22343: API routes for SMTP servers CRUD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108648&action=edit Bug 22343: Add ->transport method This patch adds a Koha::SMTP::Server->transport method that returns an Email::Sender::Transport::SMTP object generated with the current object's settings. Special case is handled for disabled SSL. This is all covered by the introduced tests. 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108650&action=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108652&action=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108654&action=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108656&action=edit Bug 22343: (QA follow-up) Fix unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #101 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. If you edit a server without password, there is "****" anyway I tried to fix it, and only display '****' if the password is defined. But then found another bug, you cannot remove the password field once it has been filled already. 2. Escaping/unescaping issues. Fixed in a follow-up patch. 3. Deletion - Why are not you using the DELETE route? Here you are cheating, I don't think we should GET with "op=delete", the parameters stay in the url 4. flagsrequired => { parameters => 1 }, Are you sure it's what we want? Not a dedicated subperm? 5. "SMTP servers Define which SMTP servers to use." is displayed on the admin home page regardless the logged in user has enough permission (click then get "Error: You do not have permission to access this page.") 6. - $params->{from} ||= C4::Context->preference('KohaAdminEmailAddress'); + my $from = $params->{from} // C4::Context->preference('KohaAdminEmailAddress'); Any good reasons? I'd stick with || to catch "" 7. I have tried to cheat and insert twice a default server, on the form edit the dropdown and select value "" (create it) I don't get any errors and see in the log "Cannot add or update a child row: a foreign key constraint fails" for the branch fk I then noticed you used "*" In admin/smtp_servers.pl: 77 catch { 78 if ( blessed $_ and $_->isa('Koha::Exceptions::Object::DuplicateID') ) { else? We are hiding a potential error/exception. We must log it anyway and make the interface display "something wrong happened" 8. Should not we display the "default config" if no default server is defined? 9. And, finally, is this working? I don't think so. kohadev-koha@kohadevbox:/kohadevbox/koha$ perl misc/cronjobs/process_message_queue.pl Use of uninitialized value for string at /usr/share/perl5/Email/MIME/Encode.pm line 66. Undefined subroutine &Email::Sender::Simple::sendmail called at /kohadevbox/koha/C4/Letters.pm line 1386. at /kohadevbox/koha/C4/Letters.pm line 1405. % pmvers Email::Sender::Simple 1.300034 If I replace Email::Sender::Simple::sendmail with sendmail (following the POD of the module), I get: sending email message to patron: 51 at /kohadevbox/koha/C4/Letters.pm line 1007. Use of uninitialized value for string at /usr/share/perl5/Email/MIME/Encode.pm line 66. Don't know how to handle Koha::Email at /usr/share/perl5/Email/Sender/Role/CommonSending.pm line 78. at /kohadevbox/koha/C4/Letters.pm line 1405. Proving tests is not a sufficient test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108716&action=edit Bug 22343: Trivial code simplification -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #105 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #104)

(In reply to Jonathan Druart from comment #101) That's because I based it on branches.pl and didn't want to make this bug dependent on an open discussion on how to use the API. I can anyway make the modal call the DELETE route and refresh the datatable.

...

4. flagsrequired => { parameters => 1 }, Are you sure it's what we want? Not a dedicated subperm?

That's actually a good idea, I will probably add it here. Kyle suggested something along the same lines. parameters => smtp_servers?

Yes

...

8. Should not we display the "default config" if no default server is defined?

Would you display above the datatable? Or just as another row?

Above the table sounds good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108646|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #107 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109004&action=edit Bug 22343: Add parameters => manage_smtp_servers subpermission This patch introduces a new subpermission for managing SMTP servers, for granularity. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #109 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109006&action=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #111 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109008&action=edit Bug 22343: Add Koha::Library->smtp_server -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #113 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109010&action=edit Bug 22343: API routes for SMTP servers CRUD This patch introduces API routes for handling SMTP servers. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #115 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109012&action=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #117 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109014&action=edit Bug 22343: Adapt Koha::Illrequest This patch makes Koha::Illrequest use the new syntax for Koha::Email and sending the email. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #119 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109016&action=edit Bug 22343: Adapt runreport.pl This script gets adapted to use the new Koha::Email syntax and SMTP transport. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #121 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109018&action=edit Bug 22343: Allow choosing an SMTP server in branches.pl The missing piece on this patchset is choosing the desired SMTP server for each library. This patch adds the option on editing the library. The default one is picked for existing libraries, and you can pick the one you want. To test: 1. Apply the patchset 2. Run: $ updatedatabase => SUCCESS: Things go smooth 3. Notice the new permission for managing SMTP servers 4. Notice the entry in the admin page 5. Add/have a few SMTP servers defined. 6. Edit a library => SUCCESS: The 'Default' SMTP server is picked 7. Choose any server and save => SUCCESS: Saving doesn't explode 8. Edit the server => SUCCESS: Your selection is kept (this can also be checked on the DB, the library_smtp_server table) 9. Try (7) with many different options => SUCCESS: It works 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #122) Please provide a full test plan. There is still no reference to testing process_message queue and other ways to send email. Which seems to be the core changes here.

This has taken too long already.

Well, first patchset attached less than 1 month ago, I would not say "too long"... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #125 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The test plan was spread between different commits and some steps were missing. I'll try to sumarize Test plan: 0. Install a new dependency: $ apt install libemail-stuffer-perl 1. Apply this patchset 2. Run: $ updatedatabase 3. Run all the tests: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: All tests pass 4. Add a privileged user, notice there's a 'manage_smtp_servers' subpermission in 'parameters' 5. Play with adding/removing the permission and reloading the admin page => SUCCESS: the admin page displays/doesn't display the entry for SMTP servers management correctly. 6. Enter the SMTP servers page => SUCCESS: the left column displays an entry for the SMTP admin page 7. Have a known working SMTP configuration (I used an app-specific password on my Gmail account), enable debug mode if you want deeper knowledge on what's happening, on the logs 8. Add the SMTP server => SUCCESS: The table displays the server 9. Add/Edit/Remove dummy servers => SUCCESS: Things work as expected 10. Go to the libraries admin page 11. Edit all libraries, choosing the known working SMTP server 12. Try sending a cart or list from the admin interface and the OPAC => SUCCESS: It works! Or otherwise the logs show why it failed, YAY! 13. Generate some notices (fulfilled holds, checkin notices, etc) 14. Run: k$ perl misc/cronjobs/process_message_queue.pl => SUCCESS: Email goes out! 15. Sign off :-D A note about 'runreport.pl'. 'runreport.pl' is THE script that doesn't have an obvious 'library' associated to it. At least not without a change in behaviour. As this patches allow you to set an SMTP server for a library, but keep a hardcoded default that replicates the current behaviour (localhost:25, no auth, no ssl/tls) the only way to test this is by having an SMTP server (postfix?) running locally. Or with bug 26290, by setting the default in koha-conf.xml. On my tests, what I did was putting my SMTP config in Koha/SMTP/Servers.pm in the default hashref. That's another option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #127 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109155&action=edit Bug 22343: Add a new table to store SMTP servers configs This patch adds a new table to store SMTP servers configs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #129 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109157&action=edit Bug 22343: Add new tables schema file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #131 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109159&action=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #133 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109161&action=edit Bug 22343: Update cpanfile -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #135 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109163&action=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #137 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109165&action=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #139 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109167&action=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Also the syntax for Koha::Email has changed and this patch adapts it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #141 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109169&action=edit Bug 22343: Prevent passing password to the UI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #143 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #126)

Why using warnings_exist instead of warning_is in the tests?

That's a left over from a previous iteration. Fixed! And thanks for pointing it out -- You are receiving this mail because: You are watching all bug changes.