https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69677&action=edit Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 18 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69677|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69679&action=edit Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19096 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69680|0 |1 is obsolete| | --- Comment #7 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71403&action=edit Bug 19790: Add a db revision for existing installs Since many installs may still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71402|0 |1 is obsolete| | Attachment #71403|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71406&action=edit Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|Trivial patch |Medium patch --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- DB update - not trivial :) https://wiki.koha-community.org/wiki/Submitting_A_Patch -- You are receiving this mail because: You are watching all bug changes.