https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92453&action=edit Bug 23501: Drag-and-drop hold reordering in the staff client This patch adds drag-and-drop priority reordering to the table of existing holds on a title. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to Koha as a user who has permission to modify holds priority - Test on a record that has multiple holds, including one which is waiting and one which is in transit. - Holds which can be re-ordered should have a "drag handle" styled table cell in the first column. - Your mouse should show the "move" cursor when you hover over it. - Clicking and dragging from this table cell should reorder the table rows. - The priority numbers should be automatically updated when you "drop" the row. - It should not be possible to move a hold which is waiting or in transit. - It should not be possible to move a hold before a waiting or in transit hold. - Toggle lowest priority on a hold. The row should become unsortable, and it should be impossible to sort a hold below that hold. - Test again as a user who doesn't have permission to modify holds priority. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92453|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92465&action=edit Bug 23501: Drag-and-drop hold reordering in the staff client This patch adds drag-and-drop priority reordering to the table of existing holds on a title. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to Koha as a user who has permission to modify holds priority - Test on a record that has multiple holds, including one which is waiting and one which is in transit. - Holds which can be re-ordered should have a "drag handle" styled table cell in the first column. - Your mouse should show the "move" cursor when you hover over it. - Clicking and dragging from this table cell should reorder the table rows. - The priority numbers should be automatically updated when you "drop" the row. - It should not be possible to move a hold which is waiting or in transit. - It should not be possible to move a hold before a waiting or in transit hold. - Toggle lowest priority on a hold. The row should become unsortable, and it should be impossible to sort a hold below that hold. - Test again as a user who doesn't have permission to modify holds priority. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Thank you for the signoff Maryse! I did think of something I wanted to add to this, so I'm going to put it back to "assigned" and submit a follow-up. I want there to be some kind of way to indicate to the user that they have to save their changes after reordering priority. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #5)

Maybe a banner down at the bottom by the buttons in red text saying changes have not been saved yet?

I've been puzzling about the text. "Your changes have not been saved yet" ? Is that explanatory enough? I'm adding the alert for "Are you sure you want to leave, your changes have not been saved," but browsers don't let you customize the text anymore so it can't specifically mention the hold priority. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #7)

Could we add one of these warnings when you try to leave the page without saving?

I like that you kept the arrows for now. I wonder if we need the arrows for accessibility of if the priority pull down would be enough.

I'm thinking that with the pull down we could eliminate either the dropdowns or the arrows, but not both. If you have a long list, drag and drop might be cumbersome. At least with the arrows, we could do away with the two arrows that bump the item up or down one position, but we should keep the arrows that bump to the top or bottom of the list. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Another thought...I like the idea of the action menu, but one thing that is needed is to visually see that items are pinned to the bottom. We don't have that, from what I gather. I'm thinking, loose the bump up and down arrows, and keep a pushpin on the end. Have it change color when in use (unless there is a another pushpin in a another position. That way it visually signals that it is in use. That would leave just the bump to top and bottom in the action menu. Personally, my thoughts are that it not THAT cumbersome to just use the dropdown for the numbers. The scrollbar makes that pretty simple. BUT, I'm wondering if those two options could be added to the top of the choice of numbers. For that matter, could Suspend and Cancel be added as well? Or maybe it is tossing to much at it? Thoughts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drag-and-drop hold |Drag-and-drop hold |reordering in the staff |reordering in the staff |client |interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.