[Bug 19067] New: clubs/ is not correctly mapped in Makefile.PL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Bug ID: 19067 Summary: clubs/ is not correctly mapped in Makefile.PL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org The clubs/ dir is not correctly mapped in Makefile.PL and thus not installed (on source installs and packages as well). To reproduce: - Run $ grep clubs Makefile.PL => FAIL: no reference to the dir -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65762&action=edit Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65765&action=edit Bug 19067: Test Makefile.PL mapping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65762|0 |1 is obsolete| | Attachment #65765|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65774&action=edit [SIGNED OFF] Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am upping severity - this bug means you can't use the hightlighted feature at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65775&action=edit [SIGNED OFF] Bug 19067: Test Makefile.PL mapping Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Krishna K <krishna.moorthy94@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krishna.moorthy94@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65774|0 |1 is obsolete| | Attachment #65775|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65813&action=edit Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65814&action=edit Bug 19067: Test Makefile.PL mapping Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No patron clubs in 16.11.x, so not needed there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 19352 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #12 from Liz Rea <liz@catalyst.net.nz> --- Man it would have been nice if the symptom of this had been listed somewhere in the bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19067 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Liz Rea from comment #12)
Man it would have been nice if the symptom of this had been listed somewhere in the bug report.
It would have been nice. Agreed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org