[Bug 8936] New: Search RSS feeds does not show there items when subscribing in Firefox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Priority: P5 - low Change sponsored?: --- Bug ID: 8936 Assignee: oleonard@myacpl.org Summary: Search RSS feeds does not show there items when subscribing in Firefox Severity: minor Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha In OPAC and with Firefox, after a search, click on RSS icon. When language is not english (translated templates), the subscribing page does not show items. When adding RSS feeds to a reader, the items are well displayed. Small bug but most readers will think the RSS feeds does not work. 'RequestOnOpac' syspref must be off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12880&action=edit Proposed patch It appears a paragraph tag <p> is broken when RequestOnOpac is on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8937 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12886&action=edit Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a <div class="dialog alert"> (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Sorry for the incorrect attachment, git bz typo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- This isn't working for me, I think. In English before and after applying the patch, I get something like this. **** EXAMPLE **** Search for 'kw,wrdl: learn' Search results for 'kw,wrdl: learn' at Learning Ruby /By Fitzgerald, Michael,. Sebastopol, Calif. : O'Reilly, 2007 . xv, 238 p. : , "The language that powers Rails."--Cover. 24 cm.. 9780596529864 (pbk.) | 0596529864 (pbk.) Place Hold on Learning Ruby /Learning Perl /By Schwartz, Randal L.. Beijing ; | Sebastopol : O'Reilly, 2011 . xxi, 363 p. : , Includes index. 24 cm.. 9781449303587 Place Hold on Learning Perl / ***** /EXAMPLE **** Before and after the patch when switched to French, I get this: ***** EXAMPLE ***** Search for 'kw,wrdl: learn' Search results for 'kw,wrdl: learn' at Learning Ruby / Learning Perl / ***** /EXAMPLE ***** The results are a be mangled from copying and pasting, but basically, I'm not seeing any changes. If I am testing incorrectly, please let me know and post a test plan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- test plan : ----------- The problem is more important in translated OPAC. But still, in 'en' you can still reproduce the bug : - Set RequestOnOpac syspref to "don't allow" - Perform a search on OPAC - Click on RSS feed button (next to result count) You get a view of RSS feeds. - Look at page source code : Ctrl+U You can see that in each <description> tag, there is a opening <p> tag with no closing </p> tag : example : <description><![CDATA[ <img src="http://images.amazon.com/images/P/2744102202.01.TZZZZZZZ.jpg" alt="" /> <p>By Maurizio FORTE. France loisirs 1996 . 295 p. , Cet ouvrage nous présente une nouvelle vision de l'intervention virtuelle,ici c'est un hymne à la gloire archéologique. 30 cm. 2744102202 </p><p> ]]></description> I hope it helps reproduce. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_8 QA Contact| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Fridolyn, it seems you provided the patch and switched to signed-off yourself. Am I missing something ? Kyle, could you test & reproduce ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #6)
Fridolyn, it seems you provided the patch and switched to signed-off yourself. Am I missing something ? Kyle, could you test & reproduce ?
Your right, patch needs sign-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12880|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13103&action=edit Bug 8936: Search RSS feeds does not show there items when subscribing in Firefox Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : * small patch that fixes html error when requetOnOpac is off * passes koha-qa.pl passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8936 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #12 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Pushed to 3.6.x will be in 3.6.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org