[Bug 22156] New: Subscription result list sorty by "checkbox"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Bug ID: 22156 Summary: Subscription result list sorty by "checkbox" Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Target Milestone: --- The subscription result list default sort is on the checkbox column (on older version it was ISSN, when that was the first column). Both are a bit confusing to libraries - I think it would make sense to have the default sort on the title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subscription result list |Subscription result list |sorty by "checkbox" |sorts on "checkbox" by | |default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|17.11 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84148&action=edit Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84149&action=edit Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ethan.amohia@gmail.com --- Comment #3 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84163&action=edit Bug 22156: Open subs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 --- Comment #4 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84164&action=edit Bug 22156: Closed subs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Ethan <ethan.amohia@gmail.com> --- As seen from the two recently added attachments, it doesn't look like the code is working as intended. The subscriptions on both the open and closed subscriptions tables are not arranged by default by title ascending. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Ethan from comment #5)
The subscriptions on both the open and closed subscriptions tables are not arranged by default by title ascending.
The sorting in the screenshots is correct. When sorting by title we ignore articles like "A" and "The." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84148|0 |1 is obsolete| | --- Comment #7 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 85193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85193&action=edit Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84149|0 |1 is obsolete| | --- Comment #8 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 85194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85194&action=edit Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85193|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85207&action=edit Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85194|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85208&action=edit Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org