[Bug 13172] New: t/Koha_Email.t depends on the database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Bug ID: 13172 Summary: t/Koha_Email.t depends on the database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: chris@bigballofwax.co.nz QA Contact: gmcharlt@gmail.com C4::Context->preference needs to be mocked -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 33005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33005&action=edit Bug 13172 t/Koha_Email.t was database dependent To test 1/ Stop your database server 2/ run t/Koha_Email.t 3/ Notice the errors 4/ Apply patch 5/ run t/Koha_Email.t again 6/ No errors (Don't forget to restart your db server after) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33005|0 |1 is obsolete| | --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 33014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33014&action=edit Bug 13172 t/Koha_Email.t was database dependent To test 1/ Stop your database server 2/ run t/Koha_Email.t 3/ Notice the errors 4/ Apply patch 5/ run t/Koha_Email.t again 6/ No errors (Don't forget to restart your db server after) Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Verified that it fixes a package build. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |robin@catalyst.net.nz Patch complexity|--- |Trivial patch --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Going to break the rules a bit here and mark this as signed off because it's needed for package builds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33014|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33015&action=edit [PASSED QA] Bug 13172 t/Koha_Email.t was database dependent To test 1/ Stop your database server 2/ run t/Koha_Email.t 3/ Notice the errors 4/ Apply patch 5/ run t/Koha_Email.t again 6/ No errors (Don't forget to restart your db server after) Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Verified that it fixes a package build. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tests pass now without database connection. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org