[Bug 11513] New: Warnings in Patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Bug ID: 11513 Summary: Warnings in Patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Floody warnings were discovered during testing Koha. To reproduce what was discovered: 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Review error log, several warnings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24106&action=edit Bug 11513 - Warnings in Patron categories TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Review error log, several warnings. 5) Apply patch 6) Refresh page 7) Review error log, no warnings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24106|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24107&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This patch silences them. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24107|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24164&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. This fix splits the admin/categorie.pl changes and the template changes, so that oldstable may be able to use this. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24164|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24169&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Merllissia Manueli <manuelimel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |manuelimel@gmail.com --- Comment #5 from Merllissia Manueli <manuelimel@gmail.com> --- Still receiving these errors: [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #6 from Merllissia Manueli <manuelimel@gmail.com> --- Still receiving these errors: [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl [Fri Jan 17 09:10:32 2014] [error] [client 127.0.0.1] [Fri Jan 17 09:10:32 2014] categorie.pl: Use of uninitialized value $enrolmentperioddate in string eq at /home/merllissia/koha/admin/categorie.pl line 248., referer: http://mykoha-intra.localhost/cgi-bin/koha/admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- I can't verify the problem, but I can see how it happens. The revised patch should solve this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24169|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24475&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Click 'Home' 13) Click 'Administration' 14) Click 'Patron categories' 15) Click '+ New category' 16) Enter a dummy category and click 'Save' 17) Click 'Edit' for the dummy category. 18) Change a value and click 'Save' 19) Click 'Delete' for the dummy category. 20) Confirm to delete. 21) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24476&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24476|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24477&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24477|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24478&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24478|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24479&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24479|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24480&action=edit Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Since my single patch failed the QA tool because of tabs, I refactored the whole indentation using perltidy, corrected the license to the current one (http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence) and then tweaked a few things by eyeball. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24480|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 24480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24480 Bug 11513 - perltidy, fix license, a couple other eyeball tweaks Forget reindenting, fixing licensing, etc. Let's keep this simple. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24475|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24481&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. Discovered tabs I had not corrected by running qa test tool. Some errors which I could not trigger were also fixed, such as line 248 shown by Merllissia Manueli. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Run the koha qa test tool. 13) Click 'Home' 14) Click 'Administration' 15) Click 'Patron categories' 16) Click '+ New category' 17) Enter a dummy category and click 'Save' 18) Click 'Edit' for the dummy category. 19) Change a value and click 'Save' 20) Click 'Delete' for the dummy category. 21) Confirm to delete. 22) Review error log, no new warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24481|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24865&action=edit [SIGNED-OFF] Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. Discovered tabs I had not corrected by running qa test tool. Some errors which I could not trigger were also fixed, such as line 248 shown by Merllissia Manueli. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Run the koha qa test tool. 13) Click 'Home' 14) Click 'Administration' 15) Click 'Patron categories' 16) Click '+ New category' 17) Enter a dummy category and click 'Save' 18) Click 'Edit' for the dummy category. 19) Change a value and click 'Save' 20) Click 'Delete' for the dummy category. 21) Confirm to delete. 22) Review error log, no new warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan, saw no errors in the log after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Enrolment is BE, Enrollment is AE But categorie sounds Dutch to me :) Just referring to script and column names here.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24931&action=edit Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. Discovered tabs I had not corrected by running qa test tool. Some errors which I could not trigger were also fixed, such as line 248 shown by Merllissia Manueli. TEST PLAN --------- 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Run the koha qa test tool. 13) Click 'Home' 14) Click 'Administration' 15) Click 'Patron categories' 16) Click '+ New category' 17) Enter a dummy category and click 'Save' 18) Click 'Edit' for the dummy category. 19) Change a value and click 'Save' 20) Click 'Delete' for the dummy category. 21) Confirm to delete. 22) Review error log, no new warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan, saw no errors in the log after applying the patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested various dates and enrollment periods with different settings of dateformat pref. Works as advertised. No warnings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Even the split on an empty string is thoroughly tested :) (I would have assumed that I got back the empty string, but perl keeps surprising..) Code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that ensures that KohaDates is used for all occurrences of the enrollment end date. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org