[Bug 8019] New: Preserve language choice between Browser sessions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Priority: P5 - low Change sponsored?: --- Bug ID: 8019 Assignee: frederic@tamil.fr Summary: Preserve language choice between Browser sessions Severity: major Classification: Unclassified OS: All Reporter: veron@veron.ch Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha If I select a language in Staff client or Opac, I expect it to be persistent between browser sessions. This is not the case. Koha forgets the selection as soon as all Broser instances are closed, and starts up the next session with the Browser's preferred language. This behaviour is due to the Cookie KohaOpacLanguage. I expires when the browser is closed because no expiry date is set in C4\Templates.pm, line 298 ff: sub setlanguagecookie { my ( $query, $language, $uri ) = @_; my $cookie = $query->cookie( -name => 'KohaOpacLanguage', -value => $language, -expires => '' ); print $query->redirect( -uri => $uri, -cookie => $cookie ); } Solution: Set -expires to a value like +3y (3 years from now) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|frederic@tamil.fr |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 9333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9333&action=edit Bug 8019 - Preserve language choice between Browser sessions Language choice in Opac an Staff client was not preserved between Browser sessions. Changed expiry date of cookie 'KohaOpacLanguage' from '' (= expire after session) to '+3y' (3 years from now) To test: - In a multilingual Koha istallation, choose a language. - Log out, close all Browser instances. Go to login screen. Login should show up in same language as before. - Repeat with other languages. modified: C4/Templates.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |marc@msys.ch, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9333|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9401&action=edit [SIGNED-OFF] Preserve language choice between Browser sessions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Works as expected, signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|major |normal --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny path, passes QA I just lowered the severity, it's not major, the user has 1 click to do to switch back to his preffered language -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_8 |rel_3_10 Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8019 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org