[Bug 7319] New: Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Bug #: 7319 Summary: Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Acquisitions AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: ian.walls@bywatersolutions.com If you search for an item via Z39.50 search to add to an order the initial search page says "Z39.50 Search Results." The title and breadcrumbs should reflect the correct stage of the operation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-12-05 14:48:31 UTC --- Created attachment 6580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6580 Proposed fix Changing title and breadcrumbs so that they correctly reflect the curent stage of the process. To test: Add to an order from an external source. When filling out the Z39.50 search form the title and breadcrumbs should read "Order from external source." After searching they should read "Order from external source -> Search results" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6580|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-06 06:25:08 UTC --- Created attachment 6590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6590 [SIGNED-OFF] Bug 7319 - Improving title and breadcrumbs on acquisitions Z39.50 search pages Changing title and breadcrumbs so that they correctly reflect the curent stage of the process. To test: Add to an order from an external source. When filling out the Z39.50 search form the title and breadcrumbs should read "Order from external sources." After searching they should read "Order from external sources -> Search results" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 15:50:33 UTC --- QA comment: Owen, shouldn't + <h2>Search results</h2> be spelled + <h2>Z39.50 Search results</h2> for an even more relevant title ? (I fear that catalogue "Search result" could be translated in a different way, and be displayed here, resulting in something strange) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-12-15 16:24:39 UTC --- (In reply to comment #3)
Owen, shouldn't + <h2>Search results</h2>
be spelled + <h2>Z39.50 Search results</h2>
A valid question. Here's my reasoning: - First, the patch changes the heading from "<h2>Results</h2>" to "<h2>Search results</h2>", so it's actually more specific than it was before. - The link which brings you to this search reads [order] "From an external source," so I added the "Order from an external source" terminology to the search page itself (in the title and breadcrumbs) - With that in mind I changed the heading of the search form from "Z39.50 Search Points" to "Order from external source." At this point there is no reference anywhere to "Z39.50" which would necessitate the use of the term on the search results page. I see that when translating from English the phrase "Search results" could be interpreted as "the results of your search" or "search the results." Is that the problem? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 09:05:44 UTC --- I think search results will work for German - it's referring to the reult list of a search not depending on the source of the results. I think a shorter description without repetitions makes is easier to read the breadcrumbs. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Patch Pushed --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 09:46:12 UTC --- QA comment: OK, katrin, you convinced me. Template change only, prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok passed QA patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org