https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |27865, 27864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120313|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120493&action=edit Bug 28261: Add visual feedback on overridden pickup locations on patron's page This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Slight display problem with long library names -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #5)

Created attachment 123111 [details] Too long library name makes the icon drop down

Display issue when library name is long

I haven't tried but maybe it's not caused by this patch. I opened bug 26288 some times ago, that seems related. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120493|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123252&action=edit Bug 28261: Add visual feedback on overridden pickup locations on patron's page This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (not related to this patch but we have .hold_location_select and .pickup_location_dropdown) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.