[Bug 22002] New: Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Bug ID: 22002 Summary: Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 83225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83225&action=edit Screenshot showing multiple rows for PREDUE notice Each message type (email, phone, print, sms) has a separate row on Home › Tools › Notices & slips. To replicate: 1) Go to Home › Tools › Notices & slips 2) Choose a letter to edit, e.g. PREDUE. Note that there is only a single row. 3) Click the edit button on the notice. 4) Expand the 'Print' section. Put text into the Message subject and Message body text areas. 5) Click save, this will take you back to the 'Notices & slips' page. 6) An extra row shows for this notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 Bug 21621: Remove incorrect GROUP BY from tools/letter.pl The test plan was not complete enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83253&action=edit Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it Caused by commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 Bug 21621: Remove incorrect GROUP BY from tools/letter.pl The test plan was not complete enough. Test plan: 1) Go to Home › Tools › Notices & slips 2) Choose a letter to edit, e.g. PREDUE. Note that there is only a single row. 3) Click the edit button on the notice. 4) Expand the 'Print' section. Put text into the Message subject and Message body text areas. 5) Click save, this will take you back to the 'Notices & slips' page. 6) Clone PREDUE for a specific library 7) The 'all libraries' option must list the templates for all libraries, but without duplicate 8) Select a library in the dropdown list: only the templates for the given library is listed, without duplicate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Wendy Sharkey <catalog@bfli.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catalog@bfli.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83253|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 83368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83368&action=edit Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it Caused by commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 Bug 21621: Remove incorrect GROUP BY from tools/letter.pl The test plan was not complete enough. Test plan: 1) Go to Home › Tools › Notices & slips 2) Choose a letter to edit, e.g. PREDUE. Note that there is only a single row. 3) Click the edit button on the notice. 4) Expand the 'Print' section. Put text into the Message subject and Message body text areas. 5) Click save, this will take you back to the 'Notices & slips' page. 6) Clone PREDUE for a specific library 7) The 'all libraries' option must list the templates for all libraries, but without duplicate 8) Select a library in the dropdown list: only the templates for the given library is listed, without duplicate Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83368|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83854&action=edit Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it Caused by commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 Bug 21621: Remove incorrect GROUP BY from tools/letter.pl The test plan was not complete enough. Test plan: 1) Go to Home › Tools › Notices & slips 2) Choose a letter to edit, e.g. PREDUE. Note that there is only a single row. 3) Click the edit button on the notice. 4) Expand the 'Print' section. Put text into the Message subject and Message body text areas. 5) Click save, this will take you back to the 'Notices & slips' page. 6) Clone PREDUE for a specific library 7) The 'all libraries' option must list the templates for all libraries, but without duplicate 8) Select a library in the dropdown list: only the templates for the given library is listed, without duplicate Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83855&action=edit Bug 22002: (QA follow-up) Remove some debugging code from template Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for missing the issue before! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #8 from Barton Chittenden <barton@bywatersolutions.com> --- I would very much like to get this back-ported to 18.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts while trying to backport to 18.05. Can not be backported until rebased to 18.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21621 [Bug 21621] Incorrect GROUP BY in tools/letter.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85159&action=edit [18.05.X] Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it Caused by commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 Bug 21621: Remove incorrect GROUP BY from tools/letter.pl The test plan was not complete enough. Test plan: 1) Go to Home › Tools › Notices & slips 2) Choose a letter to edit, e.g. PREDUE. Note that there is only a single row. 3) Click the edit button on the notice. 4) Expand the 'Print' section. Put text into the Message subject and Message body text areas. 5) Click save, this will take you back to the 'Notices & slips' page. 6) Clone PREDUE for a specific library 7) The 'all libraries' option must list the templates for all libraries, but without duplicate 8) Select a library in the dropdown list: only the templates for the given library is listed, without duplicate Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.11 Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om Version(s)| |19.05 released in| |18.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org