[Bug 35681] New: Add support for colored messages in the output of updatedatabase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Bug ID: 35681 Summary: Add support for colored messages in the output of updatedatabase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We could use Term::ANSIColor in our database revisions to aid in highlighting different outputs, but in doing so we introduce escape sequences that look 'nasty' in the browser representation. We should add support for those sequences, allowing the same end user experience via browser or terminal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160439&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160440&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160439|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160443&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160440|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160444&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160445&action=edit Bug 35681: Add new perl dependancy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35682 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35539 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 [Bug 35539] Remove unused columns from categories table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** Bug 35682 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160443|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160447&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160444|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160448&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160445|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160449&action=edit Bug 35681: Add new perl dependancy Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding my SO as having tested but leaving as 'Needs Sign-off' for independent party. If testing on k-t-d the new cpanfile dependency can be installed individually: sudo cpanm HTML::FromANSI::Tiny -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- It looks like the HTML is generated by HTML::FromANSI::Tiny? <span style="color: #f33;">Something in red is a warning</span> It would be preferable to have it use a class instead of a style attribute so that we can customize the colors. The default red, yellow, and white options do not have adequate contrast on a white background. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160473&action=edit Bug 35681: Use CSS class instead of inline style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160447|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 160503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160503&action=edit Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update This patch adds an atomic update file and also an equivilent db_rev and increments the Koha.pm version too. Use it to test the output of updatedatebase, run via console or via the browser. Test plan 1) Start KTD without the patches applied. 2) Apply this test patch 3) Run the detabase updates via the console and confirm it looks reasonable and is colored. 4) Reset the database version in ktd `koha-mysql kohadev` `UPDATE systempreferences SET value = '23.1200002';` 5) Run the database updates via the browser; `http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure` 6) Confirm the presence of weird looking escape characters on screen. 7) Apply the next patch and run through steps 3 to 5 again, this time confirming the browser output looks good. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160448|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 160504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160504&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160449|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 160505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160505&action=edit Bug 35681: Add new perl dependancy Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160473|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 160506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160506&action=edit Bug 35681: Use CSS class instead of inline style Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds release notes| |support for colored | |messages for Koha database | |updates, in both the | |terminal and browser. | | | |These new CSS classes are | |used: | |.updatedatabase-report-red | |for warnings | |.updatedatabase-report-gree | |n for ? | |.updatedatabase-report-yell | |ow where action is | |required | |.updatedatabase-report-blue | | for information --- Comment #17 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To get the colours to show in the browser update after applying the patches: yarn build 2. Not a biggy, or a showstopper, but maybe the class names could be more semantic? Not sure if there are any rules/guidelines for this. .updatedatabase-report-red -warning .updatedatabase-report-green -? (not sure for this one) .updatedatabase-report-yellow -action-required .updatedatabase-report-blue -information 3. Also, there is no class .updatedatabase-report-white -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That sounds trivial, but is actually rather difficult due to the way they're created. I'd like to eventually switch them to use the standard bookstrap classes, it right now there no way to achieve it with the library we're using to convert ansi to html. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160750&action=edit Bug 35681: [ALT] Use ::Bootstrap version of FromANSI With the next iteration of HTML::FromANSI::Tiny we can add our own subclass to map ANSI strings to Bootstrap classes. This patch adds a local lib HTML::FromANSI::Tiny::Bootstrap module to do said mapping and then uses it in the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160751&action=edit Bug 35681: [TESTING] Add local copy of latest Tiny This temporary patch is for testing only.. we add a local copy of the updated version of HTML::FromANSI::Tiny to allow simple testing without having to manually install the pre-release module version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I have an alternative to the follow-up that switched us from inline styles to custom classes. After I opened an issue against the upstream module about mapping ANSI codes to local Classes, he quickly replied with a change to review. It works great, so I've added an alternative patch here that utilises it. The [ALT] patch is meant to replace 'Use CSS class instead of inline style' in the patchset and then the [TESTING] patch that follows it is to simplify testing whilst we wait for the upstream change to be merged (I take a local copy of the adapted class into the local koha lib so you no longer need to install from cpan to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160772&action=edit Bug 35681: Add to template This patch adds colors to the skeleton atomic update to hint at their use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- As of Jan 11 it has been added upstream: https://metacpan.org/dist/HTML-FromANSI-Tiny/changes I think we can: - Update patch "Add new perl dependancy" version to 0.107 instead of 1.05 - Remove [ALT] from commit message [ALT] Use ::Bootstrap version of FromANSI as I've made the other patches obsolete and this is no longer an alternative patch. - Obsolete the [TESTING] patch now that upstream implements it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I like this. How about adding some trivial methods like: say_warning say_failure say_success say_info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160504|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164903&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160505|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164904&action=edit Bug 35681: Add new perl dependancy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164905&action=edit Bug 35681: Use ::Bootstrap version of FromANSI With the next iteration of HTML::FromANSI::Tiny we can add our own subclass to map ANSI strings to Bootstrap classes. This patch adds a local lib HTML::FromANSI::Tiny::Bootstrap module to do said mapping and then uses it in the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160751|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164906&action=edit Bug 35681: [TESTING] Add local copy of latest Tiny This temporary patch is for testing only.. we add a local copy of the updated version of HTML::FromANSI::Tiny to allow simple testing without having to manually install the pre-release module version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160772|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164907&action=edit Bug 35681: Add to template This patch adds colors to the skeleton atomic update to hint at their use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164908&action=edit Bug 35681: Add Koha::Installer::Output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164909&action=edit Bug 35681: Use Koha::Installer::Output in template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As requested I added nice wrapper methods to keep it clear for developers how to use the new colors.. the new module is inside the Koha namespace and is covered by unit tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164903|0 |1 is obsolete| | Attachment #164904|0 |1 is obsolete| | Attachment #164905|0 |1 is obsolete| | Attachment #164906|0 |1 is obsolete| | Attachment #164907|0 |1 is obsolete| | Attachment #164908|0 |1 is obsolete| | Attachment #164909|0 |1 is obsolete| | --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164942&action=edit Bug 35681: Allow for ANSI color in database updates This patch adds support for colored output in database updates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164943&action=edit Bug 35681: Add new perl dependancy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164944&action=edit Bug 35681: Use ::Bootstrap version of FromANSI With the next iteration of HTML::FromANSI::Tiny we can add our own subclass to map ANSI strings to Bootstrap classes. This patch adds a local lib HTML::FromANSI::Tiny::Bootstrap module to do said mapping and then uses it in the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164945&action=edit Bug 35681: [TESTING] Add local copy of latest Tiny This temporary patch is for testing only.. we add a local copy of the updated version of HTML::FromANSI::Tiny to allow simple testing without having to manually install the pre-release module version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164946&action=edit Bug 35681: Add to template This patch adds colors to the skeleton atomic update to hint at their use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164947&action=edit Bug 35681: Add Koha::Installer::Output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164948&action=edit Bug 35681: Use Koha::Installer::Output in template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164949&action=edit Bug 35681: (follow-up) Pass filehandle in skeleton.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Good job! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Status|Passed QA |Signed Off --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this adds a new dependency, we need to check with our Packaging team/manager before this is pushed to main. As this doesn't appear to be packaged for Debian, I assume it will require additional work. Re-setting to signed-off for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #43 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #42)
As this adds a new dependency, we need to check with our Packaging team/manager before this is pushed to main. As this doesn't appear to be packaged for Debian, I assume it will require additional work.
Re-setting to signed-off for now.
i'll aim to add an HTML::FromANSI::Tiny package to debian.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #44 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #43)
(In reply to Katrin Fischer from comment #42)
As this adds a new dependency, we need to check with our Packaging team/manager before this is pushed to main. As this doesn't appear to be packaged for Debian, I assume it will require additional work.
Re-setting to signed-off for now.
i'll aim to add an HTML::FromANSI::Tiny package to debian.org
package is pushed to koha-staging repo, ready for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Mason, what is the next step here now? (who tests what?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Next step is to push to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #46)
Next step is to push to main
We still want to document these :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Then? We need to adjust all the db revs now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #49)
Then? We need to adjust all the db revs now.
I think that could be nice to do. We are at 57 I believe... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|support for colored |support for colored |messages for Koha database |messages for Koha database |updates, in both the |updates, in both the |terminal and browser. |terminal and browser. | | |These new CSS classes are |These new CSS classes are |used: |used: |.updatedatabase-report-red |.updatedatabase-report-red |for warnings |for warnings |.updatedatabase-report-gree |.updatedatabase-report-gree |n for ? |n for ? |.updatedatabase-report-yell |.updatedatabase-report-yell |ow where action is |ow where action is |required |required |.updatedatabase-report-blue |.updatedatabase-report-blue | for information | for information | | | |**Sponsored by** *PTFS | |Europe* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #51 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se --- Comment #52 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- If we don't backport this to 23.11 we also need to make sure that other patches that are backported to 23.11, such as bug 36986 and bug 26176 don't use this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #53 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- I'm talking about Koha::Installer::Output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- (In reply to Andreas Jonsson from comment #52)
If we don't backport this to 23.11 we also need to make sure that other patches that are backported to 23.11, such as bug 36986 and bug 26176 don't use this.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #55 from David Cook <dcook@prosentient.com.au> --- I was thinking how this doesn't fit with the "PERL14: Exports" and "PERL15: Object-oriented code and the Koha:: namespace" coding guidelines. I suppose an argument could be made that this is one of the exceptions indicated in the guidelines, but it probably could've been done like this: my $output = Koha::Installer::Output->new(); $output->success($out,"Test"); With the $output just being created at the top of the "up" sub. Too late now but just a thought. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #56 from David Nind <david@davidnind.com> --- No updates are required to the manual. The installer/data/mysql/atomicupdate/skeleton.pl includes some information. However, I think the Wiki database update page requires updating (https://wiki.koha-community.org/wiki/Database_updates). Perhaps with an example of how to use, or to incorporate into the existing examples. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #56)
No updates are required to the manual.
The installer/data/mysql/atomicupdate/skeleton.pl includes some information.
However, I think the Wiki database update page requires updating (https://wiki.koha-community.org/wiki/Database_updates). Perhaps with an example of how to use, or to incorporate into the existing examples.
We just discussed it at last meeting - we had discussed to make using mandatory, but were left with some compatibility questions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #58 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #57)
(In reply to David Nind from comment #56)
No updates are required to the manual.
The installer/data/mysql/atomicupdate/skeleton.pl includes some information.
However, I think the Wiki database update page requires updating (https://wiki.koha-community.org/wiki/Database_updates). Perhaps with an example of how to use, or to incorporate into the existing examples.
We just discussed it at last meeting - we had discussed to make using mandatory, but were left with some compatibility questions.
Thanks Katrin! I'll leave any updates to the pages to developers. Link to minutes: https://hedgedoc.ishukone.net/Development_IRC_meeting_3_July_2024# -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38299 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38299 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38299 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org