http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 --- Comment #1 from Garry Collum <gcollum@gmail.com> 2012-01-21 19:05:00 UTC --- Created attachment 7269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7269 Patch to fix display Category variables were not being sent to the template, this patch uses code from members.pl to define those variables and send them to the template. It does not fix the searching issue. The code seems to be written to search for category_type, instead of categorycode, even though the label on the search reads 'Category Code.' Should it be searching for code or type? The original category column in the results displayed the category code description followed by the category type. The searching should also be fixed in conjunction with bug 5502. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2012-02-16 02:24:15 UTC --- Created attachment 7670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7670 Bug 7318 - filtering patron card creator by category code does nothing This patch should fix the search issue - do note you have to use the *code* and not the *description* To test: * replicate the bug: * do a patron search in the patron card creator, with the sample data installed, for category code PT - you should get results from all category codes. * Apply the patch * do a patron search in the patron card creator, with the sample data installed, for category code PT * you will get only results in patron category PT. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7269|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2012-02-16 16:11:04 UTC --- That would be fab, of course. I was kind of, erm, focused on getting the actual function working. I can work on that today. :) <chants>Incremental improvement! Incremental improvement!</chants> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7670|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-19 06:55:02 UTC --- Created attachment 7751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7751 Bug 7318 - filtering patron card creator by category code does nothing This patch should fix the search issue - do note you have to use the *code* and not the *description* To test: * replicate the bug: * do a patron search in the patron card creator, with the sample data installed, for category code PT - you should get results from all category codes. * Apply the patch * do a patron search in the patron card creator, with the sample data installed, for category code PT * you will get only results in patron category PT. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Fixes the search -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-22 06:24:29 UTC --- I see 2 signed off patches here... changing status :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 17:00:30 UTC --- (In reply to comment #9)

I must be silly but I can't reproduce the problem (I misundestand what means "search by categorycode" ?) I was trying to search /cgi-bin/koha/members/member.pl, clicking +, selecting a given categorycode, it works without the patch.

where's my mistake ?

ok, forget me, it's in the title of the bug: Filtering *Patron Card Creator* by Category Code Does Nothing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I believe the second patch has not been pushed. Could someone please test this and confirm whether the problem still exists, and, if it does not, clarify what it is that fixed it? Until the question is resolved, I will not be pushing this to 3.6.x. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7672|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #14)

Paul,

Could you please push the patch still attached to this bug? It doesn't seem to be in master. It passed QA a while ago.

When I try to apply this patch, I get: Applying: Bug 7318 - filtering patron card creator by category code does nothing Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. Moving to starting point so it seems it has been applied !(In reply to comment #13)

FWIW, I reported the bug and applied the second patch. After applying the patch, the Card Creator now works as designed. I will happily endorse this patch and hope it gets pushed to stable as soon as possible. Thanks.

lsuarez, which version are you running ? that's probably the explanation ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7672|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.