[Bug 23735] New: area-userblock remains visible when empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 Bug ID: 23735 Summary: area-userblock remains visible when empty Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If IntranetmainUserblock is unused, a blank frame is still shown at the bottom of the staff client. This should be hidden or non-existant if this preference is unused. Currently, I am using jQuery to resolve this: //Hide Area User Block if Empty function isEmpty( el ){ return !$.trim(el.html()) } if (isEmpty($('#main_intranet-main div.user-info'))) { $('#area-userblock').hide(); } //End Hide -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Christopher, I have tried to re create this and cannot. If I take everything out of the IntranetmainUserblock syspref and look at the source I do not see the #area-userblock. Looking at the intranet-main.tt it looks to have an IF that will only display this section if the sysprwef has content. Did you recreate this on master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #1)
Christopher,
I have tried to re create this and cannot. If I take everything out of the IntranetmainUserblock syspref and look at the source I do not see the #area-userblock.
Looking at the intranet-main.tt it looks to have an IF that will only display this section if the sysprwef has content. Did you recreate this on master?
No. I specifically marked this for 18.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I cannot reproduce this problem in master or 18.11.09. Could you have some empty markup in the preference? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Well, I feel stupid. However, I found that if I had a blank line and used delete or backspace, even repeatedly on both, it will not get rid of everything. I have to leave the blank line and use CTRL-A and delete to get rid of anything hidden. That isn't very intuitive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- I will mark this resolved and open a new bug on removing things from these preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23735 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org