https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69416&action=edit Bug 19653: Move tools templates JavaScript to the footer: Additional tools This patch modifies the staff client "Additional tools" templates so that JavaScript is included in the footer instead of the header: - Calendar - CSV profiles - Log viewer - News - Task scheduler - Edit quotes for QOTD feature - Upload Note that the log viewer template has been modified so that the "interface" variable (passed to the template to provide the correct path to staff client assets) isn't overwritten by an "interface" variable required by the log viewer. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69416|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69427&action=edit Bug 19653: Move tools templates JavaScript to the footer: Additional tools This patch modifies the staff client "Additional tools" templates so that JavaScript is included in the footer instead of the header: - Calendar - CSV profiles - Log viewer - News - Task scheduler - Edit quotes for QOTD feature - Upload Note that the log viewer template has been modified so that the "interface" variable (passed to the template to provide the correct path to staff client assets) isn't overwritten by an "interface" variable required by the log viewer. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69557&action=edit Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. resolved the issue, sorry about that, everything is working fine!Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69559&action=edit Bug 19653: (QA followup) - Add bold style to quotes menu item on quotes-upload page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Skipping for 17.11, enhancement -- You are receiving this mail because: You are watching all bug changes.