[Bug 17886] New: Don' t show option to add to existing list if there are no lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Bug ID: 17886 Summary: Don't show option to add to existing list if there are no lists Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/virtualshelves/addbybiblionumber.pl?bibl ionumber=X OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If you add a title to a list by choosing 'Add To' -> 'List' from the toolbar on the detail page, a pop-up window is triggered. This window has a section for "Select an existing list" and "Add to a new list." The first should not display if there are no existing lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #1 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59138&action=edit Bug 17886 Don't show option to add to existing list if there are no lists Test Plan 1: Make sure that you don't have any lists and then add a Biblical Record to a list 2: You should see that you can add it to an existing list even though you don't have one. 3: Apply patch 4: Add a Biblical record and if you don't have a list then you shouldn't see the add to existing list. 5: Create a list and then add a Bibical Record and you should see the add to existing list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student@wegc | |.school.nz Assignee|gmcharlt@gmail.com |caitlingoodger.student@wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59138|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 59142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59142&action=edit Bug 17886 Don't show option to add to existing list if there are no lists Test Plan 1: Make sure that you don't have any lists and then add a Biblical Record to a list 2: You should see that you can add it to an existing list even though you don't have one. 3: Apply patch 4: Add a Biblical record and if you don't have a list then you shouldn't see the add to existing list. 5: Create a list and then add a Bibical Record and you should see the add to existing list Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claire_gravely@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello Caitling, we have the same problem at the OPAC, could you fix it as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59142|0 |1 is obsolete| | --- Comment #4 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59282&action=edit Bug 17886 Don't show option to add to existing list if there are no lists Test Plan 1: Make sure that you don't have any lists and then add a Bibliographical Record to a list in OPAC 2: You should see that you can add it to an existing list even though you don't have one. 3: Apply patch 4: Add a Bibliographical record in OPAC and if you don't have a list then you shouldn't see the add to existing list. 5: Create a list and then add a Bibiographical Record in OPAC and you should see the add to existing list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Attachment #59282|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59282 Bug 17886 Don't show option to add to existing list if there are no I believe this is the wrong solution. It is much simpler. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59381&action=edit Bug 17886: Forgot to count the lists shared to patron The private_shelves_shared_with_me structure is defined, but has 0 entries. The missing .count is the issue. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #5)
I believe this is the wrong solution. It is much simpler.
Since you're obsoleting a patch from an Academy student in favor of your own I think it's worthwhile to give a detailed explanation of your reasoning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #7)
(In reply to M. Tompsett from comment #5)
I believe this is the wrong solution. It is much simpler.
Since you're obsoleting a patch from an Academy student in favor of your own I think it's worthwhile to give a detailed explanation of your reasoning.
Sorry for taking so long to notice this. Valid point, Owen. The problem is not the 'Add To' heading section (as hinted at by the 3rd obsolete patch). The problem is not around line 40ish (as hinted at by the 1st two obsolete patches). The problem is when there are no lists, it makes no sense to show that you can select a list. The problem is the code correctly checks the count method of the two shelf types, but fails to do so on the third on line 26. By simplying adding .count to the third shelf type, the options available are properly shown. There is no need to add a condition. The existing condition was broken. Though, what I do miss about the first two patches are corrections in indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59381|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 61117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61117&action=edit Bug 17886: Forgot to count the lists shared to patron The private_shelves_shared_with_me structure is defined, but has 0 entries. The missing .count is the issue. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) run koha qa test tools. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am lost here... First patch fixed the staff interface only, now the patch fixes the opac interface only... Can we have both please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61117|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75640&action=edit Bug 17886: Don't show option to add to existing list if there are no lists This patch modifies the page for adding a title to a list so that the "Add to existing list" option doesn't appear if there are no lists defined. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) Apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) Run koha qa test tools. Perform the same tests in the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75640|0 |1 is obsolete| | --- Comment #12 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 76306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76306&action=edit Bug 17886: Don't show option to add to existing list if there are no lists This patch modifies the page for adding a title to a list so that the "Add to existing list" option doesn't appear if there are no lists defined. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) Apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) Run koha qa test tools. Perform the same tests in the staff client. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Don't show option to add to |Don't show option to add to |existing list if there are |existing list if there are |no lists |no lists in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- OPAC seems to be ok in my tests. If there is still an issue I suggest solving it with a separate bug and patch to have this moving on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76306|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76428&action=edit Bug 17886: Don't show option to add to existing list if there are no lists This patch modifies the page for adding a title to a list so that the "Add to existing list" option doesn't appear if there are no lists defined. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) Apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) Run koha qa test tools. Perform the same tests in the staff client. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 [Bug 21297] "More lists" screen missing "Select an Existing list" fieldset when all lists are public. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org