[Bug 25701] New: Facets display in random order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Bug ID: 25701 Summary: Facets display in random order Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fiona.borthwick@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org This issue has been raised by our customers following an upgrade to 19.11 but I can still reproduce at 20.05. It is also apparent on both the OPAC and the staff interface. Search the catalogue and see the results page. Facets on the left appear in one order. Repeat the same search immediately and the facets appear in a different order. There is no consistency to this random order. For example - search one: Holding Libraries Series Topics Authors Item types Places Locations Search two: Holding Libraries Topics Item types Series Authors Places Locations Each search we carry out seems to yield different facet orders. Whilst possibly cosmetic, our customers would like to see consistency - especially for the OPAC as it can cause confusion for end users. We have toggled use_zebra_facets between 0 and 1 in koha-conf.xml but makes no difference. Testing on a live server at 18.11, we can confirm that the order the facets appear remains consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support Version|19.11 |master Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105679&action=edit Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. This patch restores the behaviour we always had: facet groups must be displayed in a given order: the Zebra index (au, ccode, holdingbranch, etc.) Test plan: Apply this patch, restart all and confirm that the facets are not moving up and down when you refresh your search result page. QA note: I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14419 Severity|minor |normal Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 [Bug 14419] Expanding facets (Show more) performs a new search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105679|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 105681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105681&action=edit Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. This patch restores the behaviour we always had: facet groups must be displayed in a given order: the Zebra index (au, ccode, holdingbranch, etc.) Test plan: Apply this patch, restart all and confirm that the facets are not moving up and down when you refresh your search result page. QA note: I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop; Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #1)
Created attachment 105679 [details] [review] Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order
It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop;
Afaict the line you change in the patch never worked, we always relied on the secondary sort line you mention above. I removed the 'expand' field in my patches on 14419 set which broke the second (actual) sort I agree we should remove this line and fix the first sort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3580 [Bug 3580] Control order in which facet categories display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, did you understand why your patches break the sort? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105681|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105682&action=edit Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. This patch restores the behaviour we always had: facet groups must be displayed in a given order: the Zebra index (au, ccode, holdingbranch, etc.) Test plan: Apply this patch, restart all and confirm that the facets are not moving up and down when you refresh your search result page. QA note: I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop; Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105683&action=edit Bug 25701: Remove sort on removed field Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
Nick, did you understand why your patches break the sort?
Because I removed the 'expand' field - that was the sort that actually sorted. That initial sort did nothing. See bug 3580 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07 |19.11.07, 19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14417 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org