https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD). 1. These changed templates accessed from: Lists 2. I tested by: - Reviewing the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"... - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/ and splitting into two lists - those changed and those not changed - Working out how to access them - Creating screenshots and putting them in a document - Applying the patch (+ flush_memcached, restart_all, and cleared browser cache) - Going through the list of files again: compared to original screenshot taken, then noted whether changed or not - Noting any questions - these don't affect the sign off for this bug 3. Files changed - no visible changes noticed: - ../../includes/virtualshelves/merge/selection.tt (Not sure how to trigger the dislay of this one - not referenced by any files (git grep selection.tt ":(exclude)*.po")) - addbybiblionumber.tt (Lists > select a list > Add items > modal window to add using barcodes or biblio number) - downloadshelf.tt (No visible change. Not sure how to display from the lists area - standard formats and CSV profiles download automatically without a separate a form/page. Accessed directly using http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/downloadshelf.pl?shelfnumb...) - sendshelfform.tt (No visible change. Lists > select a list to view > Send list) - shelves.tt . Lists homepage (No visible change. Lists) . Create a new list (No visible change. Lists > New list > enter details > Save) . Edit list (No visible change. Lists > select a list > Edit > Edit list) . Transfer ownership (No visible change. Lists > select a public list > Transfer action > search for new owner > Transfer) . Add items to another list (No visible change. Lists > view a list with more than one item > select two or more items > from the toolbar select the list to add to > Save - pop up window appears with options to save or cancel) . Place a hold (select one or more items in a list > select 'Place hold' from the toolbar > taken to Catalog area to complete the holds actions) . Merge selected (select one or more items in a list > select 'Merge selected' from the toolbar > taken to Cataloguing area to start the merging records process) 4. Files not changed: - tables/shelves_results.tt (used to generate the list of lists under Your lists and Public lists - no submit buttons) - sendshelf.tt (no buttons - message sent when sending list) 5. File count check: - Number of files in folder: 5 + 1 in tables directory + 1 in merge directory = 7 - Number of files listed: 7 (5 changed in this patch) Questions 1. Should the buttons be in the div or outisde the div? Those in the white background are: - Transfer ownership: Lists > select a public list > Transfer action > search for new owner > Transfer -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.