[Bug 33538] New: Allow for independent shibboleth autocreate and sync mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Bug ID: 33538 Summary: Allow for independent shibboleth autocreate and sync mapping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: pgsengstock@wisc.edu QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Shibboleth auth's autocreate and sync functions both rely on the same //shibboleth/mapping block in koha-conf.xml. Because autocreate requires mapping and/or defaults for branchcode and categorycode, this has the undesired affect of overwriting manual edits to borrowers on later syncs if the those fields are not delivered via shibboleth and explicitly mapped. Example: 1) Patron signs in for first time and borrower account is autocreated with a default branch and categorycode. 2) Staff update patron to set new branch and category codes as needed (e.g. from "SSOAUTH" to "MAINLIB"). 3) On next sign-in, patron's mapped data is synced, but branch and category codes are overwritten with the defaults. Suggested workaround is to differentiate //shibboleth/autocreatemapping vs //shibboleth/syncmapping. This allows greater control over which fields are mapped for autocreate vs sync. This schema change would not be backward compatible, though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- At one point we had autocreate and sync both working for our use case, but since some Koha upgrade, possibly 23.05, it stopped working the way that we expected it to and have had to turn off sync. In our use case we are using SSO for library staff accounts. We had autocreate set some default level of permissions so that staff could login to the staff interface and do some basic circ when they first logged in. Then we managed elevating permissions in Koha. We had sync turned on and our SAML so that we could update staff attributes like branchcode and name in the IdP and the Koha account would update the next time the staff logged in. Originally the sync allowed for updating the user's attributes sent by SAML, but allowed for the elevated permissions to be retained. We had to turn off sync because Shibboleth started syncing the permission flags to the default and all staff lost their permissions. We don't store and send permission flags in our IdP, but to get this working again without a patch we would have to do that. I think Shibboleth's sync should only update attributes that are explicitly passed from the SAML app, so that you could configure defaults for other fields in autocreate. This is particularly useful for setting default permissions for new staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk Depends on| |39224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39224 [Bug 39224] Migrate SAML/Shibboleth configuration into Identity Providers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24880 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |ByWater Solutions list of Sponsors| | Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193700&action=edit Bug 33538: Database updates adding sync options for identity providers Adds database update and kohastructure change to include sync_on_creation and sync_on_update fields to the identity_provider_mappings table. Test plan: 1. Apply the atomic update 2. Verify new fields exist in the identity_provider_mappings table Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193701&action=edit Bug 33538: DBIx::Class schema update Auto-generated DBIx::Class schema updates from database changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193702&action=edit Bug 33538: DBIC Schema customisations Add boolean flags to the new fields added Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193703&action=edit Bug 33538: Update application to respect new sync fields Updates the Koha Object classes, API controller and definitions as well as the Auth handlers to understand the new sync fields. Test plan 1) Apply the full patchset 2) Update the sync definitions for an Identity provider 3) Login via that Identity Provider for the first time and confirm the prescribed fields synced. 4) Update some fields for your patron that correspond to both syned and unsynced fields on updates. 5) Login again via the Identity Provider and confirm unsynced fields remain unchanged and synced fields are updated back to the identity provider provided value. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193704&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193700|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195353&action=edit Bug 33538: Database updates adding sync options for identity providers Adds database update and kohastructure change to include sync_on_creation and sync_on_update fields to the identity_provider_mappings table. Test plan: 1. Apply the atomic update 2. Verify new fields exist in the identity_provider_mappings table Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195354&action=edit Bug 33538: DBIx::Class schema update Auto-generated DBIx::Class schema updates from database changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195355&action=edit Bug 33538: DBIC Schema customisations Add boolean flags to the new fields added Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195356&action=edit Bug 33538: Update application to respect new sync fields Updates the Koha Object classes, API controller and definitions as well as the Auth handlers to understand the new sync fields. Test plan 1) Apply the full patchset 2) Update the sync definitions for an Identity provider 3) Login via that Identity Provider for the first time and confirm the prescribed fields synced. 4) Update some fields for your patron that correspond to both syned and unsynced fields on updates. 5) Login again via the Identity Provider and confirm unsynced fields remain unchanged and synced fields are updated back to the identity provider provided value. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195357&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195358&action=edit Bug 33538: Add sync fields to inline mapping widget in provider form Adds sync_on_creation and sync_on_update to the attribute mapping relationship widget embedded in the identity provider form, including display columns, form fields, default values, and save logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195353|0 |1 is obsolete| | Attachment #195354|0 |1 is obsolete| | Attachment #195355|0 |1 is obsolete| | Attachment #195356|0 |1 is obsolete| | Attachment #195357|0 |1 is obsolete| | Attachment #195358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195795&action=edit Bug 33538: Database updates adding sync options for identity providers Adds database update and kohastructure change to include sync_on_creation and sync_on_update fields to the identity_provider_mappings table. Test plan: 1. Apply the atomic update 2. Verify new fields exist in the identity_provider_mappings table Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195796&action=edit Bug 33538: DBIx::Class schema update Auto-generated DBIx::Class schema updates from database changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195797&action=edit Bug 33538: DBIC Schema customisations Add boolean flags to the new fields added Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195798&action=edit Bug 33538: Update application to respect new sync fields Updates the Koha Object classes, API controller and definitions as well as the Auth handlers to understand the new sync fields. Test plan 1) Apply the full patchset 2) Update the sync definitions for an Identity provider 3) Login via that Identity Provider for the first time and confirm the prescribed fields synced. 4) Update some fields for your patron that correspond to both syned and unsynced fields on updates. 5) Login again via the Identity Provider and confirm unsynced fields remain unchanged and synced fields are updated back to the identity provider provided value. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195799&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195800&action=edit Bug 33538: Add sync fields to inline mapping widget in provider form Adds sync_on_creation and sync_on_update to the attribute mapping relationship widget embedded in the identity provider form, including display columns, form fields, default values, and save logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195795|0 |1 is obsolete| | Attachment #195796|0 |1 is obsolete| | Attachment #195797|0 |1 is obsolete| | Attachment #195798|0 |1 is obsolete| | Attachment #195799|0 |1 is obsolete| | Attachment #195800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196543&action=edit Bug 33538: Database updates adding sync options for identity providers Adds database update and kohastructure change to include sync_on_creation and sync_on_update fields to the identity_provider_mappings table. Test plan: 1. Apply the atomic update 2. Verify new fields exist in the identity_provider_mappings table Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196544&action=edit Bug 33538: DBIx::Class schema update Auto-generated DBIx::Class schema updates from database changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196545&action=edit Bug 33538: DBIC Schema customisations Add boolean flags to the new fields added Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196546&action=edit Bug 33538: Update application to respect new sync fields Updates the Koha Object classes, API controller and definitions as well as the Auth handlers to understand the new sync fields. Test plan 1) Apply the full patchset 2) Update the sync definitions for an Identity provider 3) Login via that Identity Provider for the first time and confirm the prescribed fields synced. 4) Update some fields for your patron that correspond to both syned and unsynced fields on updates. 5) Login again via the Identity Provider and confirm unsynced fields remain unchanged and synced fields are updated back to the identity provider provided value. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196547&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196548&action=edit Bug 33538: Add sync fields to inline mapping widget in provider form Adds sync_on_creation and sync_on_update to the attribute mapping relationship widget embedded in the identity provider form, including display columns, form fields, default values, and save logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39224 |40650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39224 [Bug 39224] Migrate SAML/Shibboleth configuration into Identity Providers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40650 [Bug 40650] Identity providers lack support for extended patron attribute type mapping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196543|0 |1 is obsolete| | Attachment #196544|0 |1 is obsolete| | Attachment #196545|0 |1 is obsolete| | Attachment #196546|0 |1 is obsolete| | Attachment #196547|0 |1 is obsolete| | Attachment #196548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196572&action=edit Bug 33538: Database updates adding sync options for identity providers Adds database update and kohastructure change to include sync_on_creation and sync_on_update fields to the identity_provider_mappings table. Test plan: 1. Apply the atomic update 2. Verify new fields exist in the identity_provider_mappings table Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196573&action=edit Bug 33538: DBIx::Class schema update Auto-generated DBIx::Class schema updates from database changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196574&action=edit Bug 33538: DBIC Schema customisations Add boolean flags to the new fields added Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196575&action=edit Bug 33538: Update application to respect new sync fields Updates the Koha Object classes, API controller and definitions as well as the Auth handlers to understand the new sync fields. Test plan 1) Apply the full patchset 2) Update the sync definitions for an Identity provider 3) Login via that Identity Provider for the first time and confirm the prescribed fields synced. 4) Update some fields for your patron that correspond to both syned and unsynced fields on updates. 5) Login again via the Identity Provider and confirm unsynced fields remain unchanged and synced fields are updated back to the identity provider provided value. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196576&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196577&action=edit Bug 33538: Add sync fields to inline mapping widget in provider form Adds sync_on_creation and sync_on_update to the attribute mapping relationship widget embedded in the identity provider form, including display columns, form fields, default values, and save logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196578&action=edit Bug 33538: Add tooltips to mapping sync fields explaining domain rule dependency Clarify that 'Sync on creation' only takes effect when 'Auto-register' is enabled on the matching Email Domain Rule, and that 'Sync on update' only applies when 'Update patron data on login' is enabled there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196572|0 |1 is obsolete| | Attachment #196573|0 |1 is obsolete| | Attachment #196574|0 |1 is obsolete| | Attachment #196575|0 |1 is obsolete| | Attachment #196576|0 |1 is obsolete| | Attachment #196577|0 |1 is obsolete| | Attachment #196578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197301&action=edit Bug 33538: Database updates adding sync options for identity providers Adds database update and kohastructure change to include sync_on_creation and sync_on_update fields to the identity_provider_mappings table. Test plan: 1. Apply the atomic update 2. Verify new fields exist in the identity_provider_mappings table Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197302&action=edit Bug 33538: DBIx::Class schema update Auto-generated DBIx::Class schema updates from database changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197303&action=edit Bug 33538: DBIC Schema customisations Add boolean flags to the new fields added Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197304&action=edit Bug 33538: Update application to respect new sync fields Updates the Koha Object classes, API controller and definitions as well as the Auth handlers to understand the new sync fields. Test plan 1) Apply the full patchset 2) Update the sync definitions for an Identity provider 3) Login via that Identity Provider for the first time and confirm the prescribed fields synced. 4) Update some fields for your patron that correspond to both syned and unsynced fields on updates. 5) Login again via the Identity Provider and confirm unsynced fields remain unchanged and synced fields are updated back to the identity provider provided value. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197305&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197306&action=edit Bug 33538: Add sync fields to inline mapping widget in provider form Adds sync_on_creation and sync_on_update to the attribute mapping relationship widget embedded in the identity provider form, including display columns, form fields, default values, and save logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197307&action=edit Bug 33538: Add tooltips to mapping sync fields explaining domain rule dependency Clarify that 'Sync on creation' only takes effect when 'Auto-register' is enabled on the matching Email Domain Rule, and that 'Sync on update' only applies when 'Update patron data on login' is enabled there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197305|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197319&action=edit Bug 33538: Unit tests Add and update unit tests to account for the new sync fields Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org