https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90502&action=edit Bug 23095: Correctly display circulation rules (0 vs undef)

From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior

The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Bug 23095 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #1)

Actually we are expecting the plugin to return undef but the template variable contains an empty string.

That's wrong, it's an empty string in DB. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I don't manage to reproduce it. I'm sure I'm doing something wrong, but just followed the test steps. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90510|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 90540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90540&action=edit Bug 23095: Correctly display circulation rules (0 vs undef)

From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior

The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23095 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.