[Bug 7778] New: Not possible to add new z39.50 servers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Priority: P5 - low Change sponsored?: --- Bug ID: 7778 Assignee: gmcharlt@gmail.com Summary: Not possible to add new z39.50 servers QA Contact: koha.sekjal@gmail.com Severity: blocker Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Z39.50 / SRU / OpenSearch Servers Product: Koha It's not possible to add a new z39.50 server in current master. After saving you get a success message, but the server is not added. The logs show an error: [Wed Mar 21 12:20:42 2012] [error] [client 127.0.0.1] [Wed Mar 21 12:20:42 2012] z3950servers.pl: DBD::mysql::st execute failed: called with 9 bind variables when 10 are needed at /home/katrin/kohaclone/admin/z3950servers.pl line 115., referer: http://localhost:8080/cgi-bin/koha/admin/z3950servers.pl?op=add_form -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrien.saurat@biblibre.com Assignee|gmcharlt@gmail.com |adrien.saurat@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8417&action=edit proposed patch #1 Allows creation of a new server + "use warnings" now enabled and logs cleaned -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8417|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8429&action=edit [SIGNED-OFF] Bug 7778: fixes creation of a new server It is now possible to add a new server The page also now complies with the bug 2505 request (use warnings has been added, and variables declarations corrected to prevent warnings) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly, tested adding, editing and deleting z39.50 servers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Better handles several default cases, and makes the DB query syntax much easier to read and understand. Good fix, marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- This patch also improves code quality => great job katrin ! (assigned to 3.6 but not sure the problem exist here: it would be surprising that no-one spotted it before !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Paul, it was not me, but Adrien :) He fixed it fast and made the code better :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7778 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org