[Bug 26223] New: The OPAC ISBD view does not display item information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Bug ID: 26223 Summary: The OPAC ISBD view does not display item information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: a.roussos@dataly.gr QA Contact: testopia@bugs.koha-community.org The ISBD view in the OPAC interface does not display item information. To reproduce this issue, have a biblio with at least one item attached to it and include one of the following snippets in the OPACISBD system preference, depending on your MARC flavour: MARC21: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> UNIMARC: #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha collection</th><th>Barcode</th><th>Call number (Full call number)</th><th>Numbering (volume or other part)</th>|<tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f} </td><td> {995k} </td><td> {995l}</td></tr>|</table> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |a.roussos@dataly.gr Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #1 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 108381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108381&action=edit Bug 26223: include item information in OPAC ISBD view The ISBD view in the OPAC interface does not display item information. This patch fixes that. Test plan: 0) Have a biblio with at least one item attached to it and include one of the following snippets in the OPACISBD system preference, depending on your MARC flavour: MARC21: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> UNIMARC: #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha collection</th><th>Barcode</th><th>Call number (Full call number)</th><th>Numbering (volume or other part)</th>| <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f} </td><td> {995k} </td><td> {995l}</td></tr>|</table> Switch to the OPAC ISBD view for your biblio; notice how it does not display item information. 1) Apply the patch, and restart Plack/memcached if necessary. 2) Refresh the OPAC ISBD view page, this time you should see item information as per the OPACISBD system preference setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108381|0 |1 is obsolete| | --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 108533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108533&action=edit Bug 26223: include item information in OPAC ISBD view The ISBD view in the OPAC interface does not display item information. This patch fixes that. Test plan: 0) Have a biblio with at least one item attached to it and include one of the following snippets in the OPACISBD system preference, depending on your MARC flavour: MARC21: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> UNIMARC: #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha collection</th><th>Barcode</th><th>Call number (Full call number)</th><th>Numbering (volume or other part)</th>| <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f} </td><td> {995k} </td><td> {995l}</td></tr>|</table> Switch to the OPAC ISBD view for your biblio; notice how it does not display item information. 1) Apply the patch, and restart Plack/memcached if necessary. 2) Refresh the OPAC ISBD view page, this time you should see item information as per the OPACISBD system preference setting. Signed-off-by: Ivan Dziuba <ivan.dziuba@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108533|0 |1 is obsolete| | --- Comment #3 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 108534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108534&action=edit Bug 26223: include item information in OPAC ISBD view The ISBD view in the OPAC interface does not display item information. This patch fixes that. Test plan: 0) Have a biblio with at least one item attached to it and include one of the following snippets in the OPACISBD system preference, depending on your MARC flavour: MARC21: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> UNIMARC: #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha collection</th><th>Barcode</th><th>Call number (Full call number)</th><th>Numbering (volume or other part)</th>| <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f} </td><td> {995k} </td><td> {995l}</td></tr>|</table> Switch to the OPAC ISBD view for your biblio; notice how it does not display item information. 1) Apply the patch, and restart Plack/memcached if necessary. 2) Refresh the OPAC ISBD view page, this time you should see item information as per the OPACISBD system preference setting. Signed-off-by: Ivan Dziuba <ivan.dziuba@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba@inlibro.com --- Comment #4 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- This patch doesn't work ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Does the information just not show? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #6 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Katrin Fischer from comment #5)
Does the information just not show?
yes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Ivan Dziuba from comment #4)
This patch doesn't work ... (In reply to Ivan Dziuba from comment #6) (In reply to Katrin Fischer from comment #5)
Does the information just not show?
yes Hi Ivan! I just tried to apply the patch on top of the current master (51fd1db) and it worked fine. I'm not sure why it didn't work for you, can you elaborate on what steps you followed, please?
I'm setting the status to 'Needs Signoff' to get more eyes on this... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108381|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Sorry this doesn't work for me either :( I applied the patch, modified the OPACISBD system preference, "restart_all," and refreshed the page in the OPAC. No item information shows on the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I think this is caused by Bug 22696 We should come back to calling : my $record = GetMarcBiblio({ biblionumber => $biblionumber, embed_items => 1, opac => 1, borcat => $borcat }); Like for example in opac-export.pl : https://git.koha-community.org/Koha-community/Koha/src/branch/20.11.x/opac/o... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch is working for me. 1. Use KTD 2. Edit OPACISBD and add the following content at the end: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> 3. /cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=11 With this patch I see the table: https://snipboard.io/usn5j7.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108381|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124099&action=edit Bug 26223: include item information in OPAC ISBD view The ISBD view in the OPAC interface does not display item information. This patch fixes that. Test plan: 0) Have a biblio with at least one item attached to it and include one of the following snippets in the OPACISBD system preference, depending on your MARC flavour: MARC21: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> UNIMARC: #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha collection</th><th>Barcode</th><th>Call number (Full call number)</th><th>Numbering (volume or other part)</th>| <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f} </td><td> {995k} </td><td> {995l}</td></tr>|</table> Switch to the OPAC ISBD view for your biblio; notice how it does not display item information. 1) Apply the patch, and restart Plack/memcached if necessary. 2) Refresh the OPAC ISBD view page, this time you should see item information as per the OPACISBD system preference setting. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It seems to me that the order in which the filters are listed should be swapped. We want the items to be embedded and THEN their subfields filtered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Well, and I would do: my @items = $biblio->items->filter_by_visible_in_opac; it will save lots of CPU cycles in some cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124099|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124101&action=edit Bug 26223: include item information in OPAC ISBD view The ISBD view in the OPAC interface does not display item information. This patch fixes that. Test plan: 0) Have a biblio with at least one item attached to it and include one of the following snippets in the OPACISBD system preference, depending on your MARC flavour: MARC21: #952|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha item type</th><th>Barcode</th><th>Call number (Full call number)</th><th>Materials specified (bound volume or other part)</th>|<tr><td>{952t} </td><td> {952c} </td><td> {952y} </td><td> {952p} </td><td> {952o} </td><td> {9523}</td></tr>|</table> UNIMARC: #995|<br/><h2>Items</h2><table><th>Copy number</th><th>Shelving location</th><th>Koha collection</th><th>Barcode</th><th>Call number (Full call number)</th><th>Numbering (volume or other part)</th>| <tr><td>{9956} </td><td> {995e} </td><td> {995h} </td><td> {995f} </td><td> {995k} </td><td> {995l}</td></tr>|</table> Switch to the OPAC ISBD view for your biblio; notice how it does not display item information. 1) Apply the patch, and restart Plack/memcached if necessary. 2) Refresh the OPAC ISBD view page, this time you should see item information as per the OPACISBD system preference setting. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124102&action=edit Bug 26223: (QA follow-up) Fix filter order Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124102|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124103&action=edit Bug 26223: (QA follow-up) Fix filter order Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.04 |21.11.00,21.05.04,20.11.10 released in| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org