[Bug 16552] New: Add the ability to change the default holdings sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Bug ID: 16552 Summary: Add the ability to change the default holdings sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org This new enhancement will add the ability to change the default holdings sort on OPAC displays to be by library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51615&action=edit Bug 16552: Add the ability to change the default holdings sort This new enhancement will add the ability to change the default holdings sort on OPAC displays to be by library, instead of item type. This patch adds a new pref OPACHoldingsDefaultSortField with 3 different possible values: - Item type - Home library - Holding library Note that if OpacLocationBranchToDisplay is set not to display home libraries, unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to "Home library", same for "Holding library". Test plan: - Confirm that the default value for OPACHoldingsDefaultSortField is 'first column' after executing the DB entry and that there is no change in the behavior (first column is used to sort the holdings table on the detail page). - Set OpacLocationBranchToDisplay to both and play with the different values of OPACHoldingsDefaultSortField => Confrm that the default column used to sort the table is correctly changed - Set the pref SeparateHoldings on => Confirm that both tables (Holdings and other holdings) are sorted using the OPACHoldingsDefaultSortField value. Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I ran into one problem with this. These were the combinations I tested: OPACHoldingsDefaultSortField -> Item type - OpacLocationBranchToDisplay -> home library - Good - OpacLocationBranchToDisplay -> holding library - Good - OpacLocationBranchToDisplay -> home and holding library - Good OPACHoldingsDefaultSortField -> Home library - OpacLocationBranchToDisplay -> home library - Sorts on third column, "Collection" - OpacLocationBranchToDisplay -> holding library - (Not applicable) - OpacLocationBranchToDisplay -> home and holding library - Good OPACHoldingsDefaultSortField -> Holding library - OpacLocationBranchToDisplay -> home library - (Not applicable) - OpacLocationBranchToDisplay -> holding library - Good - OpacLocationBranchToDisplay -> home and holding library - Good When I have OPACHoldingsDefaultSortField set to "Home library" and OpacLocationBranchToDisplay set to "home library" the sorting is on the "Collection" column instead of the home library one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51615|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51636&action=edit Bug 16552: Add the ability to change the default holdings sort This new enhancement will add the ability to change the default holdings sort on OPAC displays to be by library, instead of item type. This patch adds a new pref OPACHoldingsDefaultSortField with 3 different possible values: - Item type - Home library - Holding library Note that if OpacLocationBranchToDisplay is set not to display home libraries, unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to "Home library", same for "Holding library". Test plan: - Confirm that the default value for OPACHoldingsDefaultSortField is 'first column' after executing the DB entry and that there is no change in the behavior (first column is used to sort the holdings table on the detail page). - Set OpacLocationBranchToDisplay to both and play with the different values of OPACHoldingsDefaultSortField => Confrm that the default column used to sort the table is correctly changed - Set the pref SeparateHoldings on => Confirm that both tables (Holdings and other holdings) are sorted using the OPACHoldingsDefaultSortField value. Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #2)
When I have OPACHoldingsDefaultSortField set to "Home library" and OpacLocationBranchToDisplay set to "home library" the sorting is on the "Collection" column instead of the home library one.
Indeed, the tests are a bit more complicated :) Thanks for testing Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com --- Comment #5 from Jonathan Field <jonathan.field@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #4)
(In reply to Owen Leonard from comment #2)
When I have OPACHoldingsDefaultSortField set to "Home library" and OpacLocationBranchToDisplay set to "home library" the sorting is on the "Collection" column instead of the home library one.
Indeed, the tests are a bit more complicated :) Thanks for testing Owen!
Unless I'm misunderstanding this, on my sandbox, it sorts correctly with OPACHoldingsDefaultSortField -> Home library - OpacLocationBranchToDisplay -> home library - Sorts on third column, "Collection" - OpacLocationBranchToDisplay -> holding library - (Not applicable) - OpacLocationBranchToDisplay -> home and holding library - Good That is, the Home Library column is selected and active. My column layout is Item type, Home Library, Collection, Call #, Status, Due Date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 51943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51943&action=edit Bug 16552: Add the ability to change the default holdings sort This new enhancement will add the ability to change the default holdings sort on OPAC displays to be by library, instead of item type. This patch adds a new pref OPACHoldingsDefaultSortField with 3 different possible values: - Item type - Home library - Holding library Note that if OpacLocationBranchToDisplay is set not to display home libraries, unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to "Home library", same for "Holding library". Test plan: - Confirm that the default value for OPACHoldingsDefaultSortField is 'first column' after executing the DB entry and that there is no change in the behavior (first column is used to sort the holdings table on the detail page). - Set OpacLocationBranchToDisplay to both and play with the different values of OPACHoldingsDefaultSortField => Confrm that the default column used to sort the table is correctly changed - Set the pref SeparateHoldings on => Confirm that both tables (Holdings and other holdings) are sorted using the OPACHoldingsDefaultSortField value. Sponsored-by: University of the Arts London Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works as described. I can imagine sometime in the future multiple criteria for sorting could be desirable. For example: home library, itemtype. Or: Home library, enumchron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51943|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55668&action=edit [PASSED QA] Bug 16552: Add the ability to change the default holdings sort This new enhancement will add the ability to change the default holdings sort on OPAC displays to be by library, instead of item type. This patch adds a new pref OPACHoldingsDefaultSortField with 3 different possible values: - Item type - Home library - Holding library Note that if OpacLocationBranchToDisplay is set not to display home libraries, unexpected behaviors might happen if OPACHoldingsDefaultSortField is set to "Home library", same for "Holding library". Test plan: - Confirm that the default value for OPACHoldingsDefaultSortField is 'first column' after executing the DB entry and that there is no change in the behavior (first column is used to sort the holdings table on the detail page). - Set OpacLocationBranchToDisplay to both and play with the different values of OPACHoldingsDefaultSortField => Confrm that the default column used to sort the table is correctly changed - Set the pref SeparateHoldings on => Confirm that both tables (Holdings and other holdings) are sorted using the OPACHoldingsDefaultSortField value. Sponsored-by: University of the Arts London Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16552 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org