[Bug 5898] New: search to hold feature not clearing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Bug #: 5898 Summary: search to hold feature not clearing Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Hold requests AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com If I choose to 'search to hold' from a patron record and then log out of the staff client, when I log back it in still remembers the patron I was searching to hold for. Also, there isn't a mechanism to clear the system memory of this patron's info so for the rest of your session the 'hold for patron name' link appears on search results - I know why this is, but there should be a way (like the 'clear' button on the checkout page) to clear the patron the system remember so that holds are accidentally placed in that patron's name. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |oleonard@myacpl.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-03-28 15:06:23 UTC --- Just to lay out the way it *should* be working: - The cookie expires after 10 minutes - The cookie is cleared when you pull up another patron in circulation - All hold links and buttons should be clearly labeled to prevent placing holds for the wrong person It was suggested in the original bug that the expiration time be a system preference. I'm all for that but haven't worked in it. I consider it a bug that the cookie doesn't clear when you load up a "blank" circ screen (i.e. submit an empty checkout form). When this is fixed clicking the "Clear" button on the checkout page will also clear the search-to-hold cookie. I agree that it is a bug that the cookie isn't cleared when you log out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-09-23 18:25:33 UTC --- Created attachment 5571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5571 Proposed fix Search to hold cookie is now cleared when the user loads a blank circulation page and when the user logs out. The user also now has the option to "forget" the current search to hold patron by choosing an option from the search to hold menu on the search results page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-09-23 18:27:59 UTC --- Created attachment 5572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5572 Screenshot snippet of the revised hold menu on search results -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-09-23 18:46:49 UTC --- Created attachment 5573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5573 [Signed Off] Fix for Bug 5898 - search to hold feature not clearing Search to hold cookie is now cleared when the user loads a blank circulation page and when the user logs out. The user also now has the option to "forget" the current search to hold patron by choosing an option from the search to hold menu on the search results page. Signed-off-by: Liz Rea <lrea@nekls.org> Tested: Forget <patron> from search to hold results clears cookie Logging out clears the cookie - testing note: i had to clear my cookies and test fresh before this would work Loading a blank circulation page (Check Out from the circulation-home) clears the cookie. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5571|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5573|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 13:44:40 UTC --- Created attachment 5852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5852 Fix for Bug 5898 - search to hold feature not clearing Search to hold cookie is now cleared when the user loads a blank circulation page and when the user logs out. The user also now has the option to "forget" the current search to hold patron by choosing an option from the search to hold menu on the search results page. Signed-off-by: Liz Rea <lrea@nekls.org> Tested: Forget <patron> from search to hold results clears cookie Logging out clears the cookie - testing note: i had to clear my cookies and test fresh before this would work Loading a blank circulation page (Check Out from the circulation-home) clears the cookie. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 13:49:00 UTC --- QA comment * Nicole description is OK & is a test plan * no specific comment to do about the code * works as expected. OWEN : Why didn't you have added the "Forget xxx (xxx)" to the action toolbar on the biblio detail page ? It would be more consistent However : marked passed QA, please keep this bug open anyway even if RM pushes it, until owen has provided a follow-up for the detail page or explained why there should not be a button on this page Note for RM regarding string freeze: small string change in this patch : new string to forget patron. Fixes an annoying and small problem, I think it's worth waiting 3.6.1, but it's up to you to decide. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 13:55:01 UTC --- I agree with Paul's QA assessment; marking as Passed. A followup to add this clear option to patron details page would be welcomed, but I don't believe is necessary for the workflow typically surrounding this patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-10-12 14:33:55 UTC --- (In reply to comment #6)
OWEN : Why didn't you have added the "Forget xxx (xxx)" to the action toolbar on the biblio detail page ? It would be more consistent
Great suggestion, I'll work on that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-12 22:16:01 UTC --- Minor string changes only, most changes in the js, shouldn't affect to much translator -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5898 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org