https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91483&action=edit Bug 23304: Reindent cataloguing/z3950_search.tt This patch reindents cataloguing/z3950_search.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed, and some minor markup errors have been corrected for validity. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not giving orders, you do you. Go to Cataloging -> New from Z39.50/SRU. Test that the search form and results look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91490|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91491&action=edit Bug 22304: (follow-up) Add markup structure comments This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91483|0 |1 is obsolete| | --- Comment #4 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91498&action=edit Bug 23304: Reindent cataloguing/z3950_search.tt This patch reindents cataloguing/z3950_search.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed, and some minor markup errors have been corrected for validity. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not giving orders, you do you. Go to Cataloging -> New from Z39.50/SRU. Test that the search form and results look correct and work correctly. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nadine.pierre@InLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91498|0 |1 is obsolete| | Attachment #91499|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91635&action=edit Bug 23304: Reindent cataloguing/z3950_search.tt This patch reindents cataloguing/z3950_search.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed, and some minor markup errors have been corrected for validity. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not giving orders, you do you. Go to Cataloging -> New from Z39.50/SRU. Test that the search form and results look correct and work correctly. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.