[Bug 19798] New: Returns.pl doesn't define itemnumber for transfer-slip.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Bug ID: 19798 Summary: Returns.pl doesn't define itemnumber for transfer-slip. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bjorn.nylen@ub.lu.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Marking master as version as 17.11 isn't available to select. It seems the itemnumber isn't set in the link/button that prints transfer-slips. To reproduce: 1. Check in available/not on hold item at a non owning library. 2. Press transfer-button. 3. Resulting slips says "Item not found". "Inspect element" in browser for the button indicates that itemnumber is not set: "transfer-slip.pl?transferitem=&branchcode=CPL&op=slip" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Depends on| |18276 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This bug may have been caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69925&action=edit Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19840 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Related with bug 19840 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Björn Nylén <bjorn.nylen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70169&action=edit Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70169|0 |1 is obsolete| | --- Comment #6 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 70181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70181&action=edit Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70181|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 70198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70198&action=edit Bug 19798: Fix print transfer slip ... and maybe other bugs as well What happens here is that $itemnumber is no longer set when barcode is passed. Test plan: 1. Check in available/not on hold item at a non owning library. 2. Click print slip 3. Item's info must be displayed on the slip Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 18276 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org