[Bug 25892] New: Clarify the visual hierarchy of holds by branch and itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Bug ID: 25892 Summary: Clarify the visual hierarchy of holds by branch and itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 106401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106401&action=edit Screenshot showing nested fieldsets With the various settings of HoldsSplitQueue enabled the visual hierarchy of the holds list (/cgi-bin/koha/reserve/request.pl?biblionumbers=XX) can be a little muddled. See the attached screenshot. I think it would be better not to have multiple nested fieldsets and instead use a combination of fieldsets and headings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106402&action=edit Screenshot showing the proposed revision -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106403&action=edit Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 [Bug 25827] Add floating toolbar to the holds summary page in staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106403|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106412&action=edit Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org Status|Needs Signoff |Signed Off --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works as outlined. Everything looks good. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106412|0 |1 is obsolete| | CC| |emmi.takkinen@outlook.com --- Comment #5 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 106488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106488&action=edit Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106488|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106530&action=edit Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clarify the visual |Clarify the visual |hierarchy of holds by |hierarchy of holds by |branch and itemtype |library and itemtype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enhancement to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org