[Bug 21805] New: Duplicate include file in search results template causes JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Bug ID: 21805 Summary: Duplicate include file in search results template causes JS error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There is a duplicate include of browser-strings.inc in results.tt. Probably a merge error. The first one should be removed because it needs to be loaded after the global JS includes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82197&action=edit Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82197|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82202&action=edit Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-marc.thibault@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82202|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82341&action=edit Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Issue not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org