https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 Alexander Wagner <alexander.wagner@desy.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Blocks| |21303 Assignee|koha-bugs@lists.koha-commun |alexander.wagner@desy.de |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21303 [Bug 21303] XSLT should look in LDR/18 to know whether to add punctuation or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 --- Comment #1 from Alexander Wagner <alexander.wagner@desy.de> --- More samples: ``` 260 __ |a Paris : |b Impr. Vincent,$c1798 |a [i.e. Bruxelles : |b Moens, |c **1883] 260 __ |a Bethesda, Md. : |b Toxicology Information Program, National Library of Medicine [producer] ; |a Springfield, Va. : |b National Technical Information Service [distributor], |c 1974-$e(Oak Ridge, Tenn. : |f **Oak Ridge National Laboratory [generator]) ``` -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 --- Comment #3 from Alexander Wagner <alexander.wagner@desy.de> --- As fields from 260 are used to build links into Koha adding the punctuation actually clutters the search terms with these chars. IOW the actual search triggered currently is not for `Paris` but for `Paris : `. This is also true for all records that hold the punctuation, so adding it automatically does not degrade the situation and Koha seems to cope with that quite well. (This issue seems to have been discussed in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 some time ago already and the current state seems _good enough_.) To improve on this end one would need to add proper functionality to the XSLT to strip (the just added or stored) punctuation. Being limited to XSLT 1 a complete solution might get a bit complex (no regexps...) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 --- Comment #5 from Alexander Wagner <alexander.wagner@desy.de> --- Created attachment 174326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174326&action=edit Bug 37325: fix XSLT for automatic punctuation of 260 XSLT uses subfields for display _as they are_. Sometimes, these values are used to build queries against Koha based on the field content. These queries may hold punctuation chars that could potentially confuse the search. - Add simple rules to strip punctuation chars in the search terms for OPAC and intranet interfaces. Test plan: 1. Call up any record holding a 260 field in Koha 2. Check the URLs of queries generated from the subfields of 260. These show search terms including punctuation chars (`,:` etc., e.g. `Edinburg :`) 3. Apply the patch 4. Punctuation chars should vanish from the URL and only the search term should survive (e.g. `Edinburg`) This fix acts on _all_ records and is not restricted to records that got their punctuation automatically. Sponsored-by: Deutsches Elektronen-Synchrotron DESY, Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 --- Comment #6 from Alexander Wagner <alexander.wagner@desy.de> --- Created attachment 174467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174467&action=edit Bug 37325: Add punctuation for 260 and 264 Add punctuation automatically for tag 260 (Imprint), if the record leader defines that punctuation is _omitted_ from the fields. The filter does not act on records that hold punctuation and say so in leader 18. - Hook up `Puncutation.pm` with `XSLT.pm` - Add rules for automatic punctuation of Marc21 field 260 according to https://www.loc.gov/aba/pcc/documents/isbdmarc2016.pdf - Subfields handled: a, b, c, f, g, r, t, q Note: there may be complex cases where it is not possible to properly add punctuation automatically from the subfield semantics alone. In these cases it is still possible to add punctuation to the record and specify this in leader 18. Then the filter will not change the record at all. Test plan: 1. Select a record (A) with a properly filled and punctuated 260 field 2. Check that the punctuation display correctly in intranet and OPAC interface 3. Select a record (B) without punctuation OR remove the punctuation from the subfields of field 260. Check that leader 18 is set to `c` or `n`, IOW that this is a semantically correct record. 4. Check that _no_ punctuation chars get displayed in OPAC or intranet 5. Apply the patch 6. Edit the record (A) 7. Check that the Marc leader position 18 is _not_ set to `c` or `n` 8. Set Marc leader 18 to `c` or `n` (`c`: ISBD punctuation omitted / `n` Non-ISBD punctuation omitted) 9. Save the record 10. Check that all punctuation chars appear twice in intranet as well as OPAC interface 11. Check record (B) in intranet and OPAC interface. It should now show automatically added, proper punctuation. For field 264: follow the procedure just outlined but use field 264 instead. If 264 is present, Koha will prefer it over 260. Sponsored-by: Deutsches Elektronen-Synchrotron DESY, Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 Alexander Wagner <alexander.wagner@desy.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174325|0 |1 is obsolete| | Attachment #174326|0 |1 is obsolete| | Attachment #174467|0 |1 is obsolete| | Attachment #174468|0 |1 is obsolete| | --- Comment #8 from Alexander Wagner <alexander.wagner@desy.de> --- Created attachment 174470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174470&action=edit Bug 37325: Add punctuation for 260 and 264 Add punctuation automatically for tag 260 (Imprint), if the record leader defines that punctuation is _omitted_ from the fields. The filter does not act on records that hold punctuation and say so in leader 18. - Hook up `Puncutation.pm` with `XSLT.pm` - Add rules for automatic punctuation of Marc21 field 260 according to https://www.loc.gov/aba/pcc/documents/isbdmarc2016.pdf - Subfields handled: a, b, c, f, g, r, t, q Note: there may be complex cases where it is not possible to properly add punctuation automatically from the subfield semantics alone. In these cases it is still possible to add punctuation to the record and specify this in leader 18. Then the filter will not change the record at all. Test plan: 1. Select a record (A) with a properly filled and punctuated 260 field 2. Check that the punctuation display correctly in intranet and OPAC interface 3. Select a record (B) without punctuation OR remove the punctuation from the subfields of field 260. Check that leader 18 is set to `c` or `n`, IOW that this is a semantically correct record. 4. Check that _no_ punctuation chars get displayed in OPAC or intranet 5. Apply the patch 6. Edit the record (A) 7. Check that the Marc leader position 18 is _not_ set to `c` or `n` 8. Set Marc leader 18 to `c` or `n` (`c`: ISBD punctuation omitted / `n` Non-ISBD punctuation omitted) 9. Save the record 10. Check that all punctuation chars appear twice in intranet as well as OPAC interface 11. Check record (B) in intranet and OPAC interface. It should now show automatically added, proper punctuation. For field 264: follow the procedure just outlined but use field 264 instead. If 264 is present, Koha will prefer it over 260. Sponsored-by: Deutsches Elektronen-Synchrotron DESY, Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@trust-box.at -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris.mathevet@inLibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37325 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.