[Bug 31307] New: already_reserved never used in opac/opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Bug ID: 31307 Summary: already_reserved never used in opac/opac-reserve.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org my $policy_holdallowed = !$itemLoopIter->{already_reserved}; This "already_reserved" is never used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 [Bug 30847] Cleanup opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138834&action=edit Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31314 [Bug 31314] Remove GetItemsInfo from opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30847 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 [Bug 30847] Cleanup opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138834|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138920&action=edit Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Trivial, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- For the record: $ git grep already_reserved | grep -v translator koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% IF ( bibitemloo.already_reserved ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% END # / IF bibitemloo.already_reserved %] opac/opac-reserve.pl: $biblioLoopIter{already_reserved} = $biblioData->{already_reserved}; opac/opac-reserve.pl: if ($biblioLoopIter{already_reserved}) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31307 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #4)
For the record:
$ git grep already_reserved | grep -v translator
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% IF ( bibitemloo.already_reserved ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: [% END # / IF bibitemloo.already_reserved %] opac/opac-reserve.pl: $biblioLoopIter{already_reserved} = $biblioData->{already_reserved}; opac/opac-reserve.pl: if ($biblioLoopIter{already_reserved}) {
Yes, the commit message could have been a bit more verbose. The flag was set to $itemLoopIter, which was never used. biblioLoopIter does use it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org