https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 Michael Skarupianski <michael.skarupianski@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 Michael Skarupianski <michael.skarupianski@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 181826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181826&action=edit Bug 39528: Remove schema.org "Product" type from OPAC record pages OPAC record detail pages include https://schema.org microdata information in the HTML page markup, such as CreativeWork. It incorrectly includes the "Product" type - this is not needed and is also rejected by some search engines, for example ... vocab="http://schema.org/" typeof="CreativeWork Product" ... (Koha maps schema.org to the RDFa Lite syntax https://www.w3.org/TR/rdfa-lite/) Test plan: 1. Look at HTML source of a details page for a record in the OPAC. 2. Search for schema.org 3. Note that it there are two typeof entries: .. vocab="http://schema.org/" typeof="CreativeWork Product" ... 4. Apply the patch. 5. Refresh the page and look at the HTML source again. 6. Note that the "Product" schema.org type is removed: .. vocab="http://schema.org/" typeof="CreativeWork" ... 7. Sign off. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 --- Comment #3 from David Nind <david@davidnind.com> --- I've attempted to rewrite the commit message (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages). Feel free to amend this to better reflect what the bug does, I'm not sure my very basic understanding schema.org microdata and how it is implemented in Koha is correct. Comments welcome! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181826|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182452&action=edit Bug 39528: Remove schema.org "Product" type from OPAC record pages OPAC record detail pages include https://schema.org microdata information in the HTML page markup, such as CreativeWork. It incorrectly includes the "Product" type - this is not needed and is also rejected by some search engines, for example ... vocab="http://schema.org/" typeof="CreativeWork Product" ... (Koha maps schema.org to the RDFa Lite syntax https://www.w3.org/TR/rdfa-lite/) Test plan: 1. Look at HTML source of a details page for a record in the OPAC. 2. Search for schema.org 3. Note that it there are two typeof entries: .. vocab="http://schema.org/" typeof="CreativeWork Product" ... 4. Apply the patch. 5. Refresh the page and look at the HTML source again. 6. Note that the "Product" schema.org type is removed: .. vocab="http://schema.org/" typeof="CreativeWork" ... 7. Sign off. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39528 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.