[Bug 39712] New: Query parameters break the manual mappings in vue modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Bug ID: 39712 Summary: Query parameters break the manual mappings in vue modules Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: aude.charillon@openfifth.co.uk, philip.orr@lmscloud.de If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38010 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #1 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Is Documentation the best component for this bug to be in? I'm afraid it's going to get lost among the requests for updates to the Manual. Would it be more relevant to use the Staff interface component? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183437&action=edit Bug 39712: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183438&action=edit Bug 39712: Fix links to the manual from VueJS components Query parameters break the manual mappings in vue modules. If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page Test plan: Confirm that the original issue is fixed when this patch is applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183439&action=edit Bug 39712: Remove extra '/' from the URL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183440&action=edit Bug 39712: Remove warnings [WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183441&action=edit Bug 39712: Add POD -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Documentation |Staff interface CC| |gmcharlt@gmail.com --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Aude Charillon from comment #1)
Is Documentation the best component for this bug to be in? I'm afraid it's going to get lost among the requests for updates to the Manual. Would it be more relevant to use the Staff interface component?
Bug 19817 was using "Documentation", but happy to change if you think "Staff interface" fits better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183437|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 183447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183447&action=edit Bug 39712: Add tests Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183438|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 183448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183448&action=edit Bug 39712: Fix links to the manual from VueJS components Query parameters break the manual mappings in vue modules. If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page Test plan: Confirm that the original issue is fixed when this patch is applied. Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183439|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 183449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183449&action=edit Bug 39712: Remove extra '/' from the URL Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183440|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 183450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183450&action=edit Bug 39712: Remove warnings [WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346. Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183441|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 183451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183451&action=edit Bug 39712: Add POD Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Fixes the issue as originally described - signing off :-) (Hoping I've done that correctly with the number of patches!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183447|0 |1 is obsolete| | --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184983&action=edit Bug 39712: Add tests Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183448|0 |1 is obsolete| | --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184984&action=edit Bug 39712: Fix links to the manual from VueJS components Query parameters break the manual mappings in vue modules. If a url in a vue module contains query parameters the mapping for the manual fails and redirects to the homepage when 'Help' is clicked To reproduce navigate to the agreements page in ERM and create at least one. On the list page, use the filters so that you have query parameters in the page URL. Click the 'Help' button - you just get the manual home page Test plan: Confirm that the original issue is fixed when this patch is applied. Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183449|0 |1 is obsolete| | --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184985&action=edit Bug 39712: Remove extra '/' from the URL Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183450|0 |1 is obsolete| | --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184986&action=edit Bug 39712: Remove warnings [WARN] Use of uninitialized value $view in exists at /kohadevbox/koha/Koha/Manual.pm line 346. Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183451|0 |1 is obsolete| | --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184987&action=edit Bug 39712: Add POD Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #20 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 Without unit test, it contains hard-coded 25.05 :O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40845 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Fridolin Somers from comment #21)
Pushed to 24.11.x for 24.11.09
Without unit test, it contains hard-coded 25.05 :O
Oops, see bug 40845. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40845 [Bug 40845] t/Koha/Manual.t only passes for 25.05 and 25.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #21)
Pushed to 24.11.x for 24.11.09
Without unit test, it contains hard-coded 25.05 :O
"Bug 39712: Add tests" also backported in 24.11.11 with Bug 40845 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #24 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39712 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #25 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org