[Bug 30779] New: Do not need to remove items from import biblios marc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Bug ID: 30779 Summary: Do not need to remove items from import biblios marc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When staging biblios we save the marc, then, if we are looking for items and find them, we save the marc without the 952 While there is a space savings here, I think the extra write is costing us with no benefit. While we could remove the items before the initial save, I think there is actually value in seeing the items in the imported marc, so one can compare what was imported to what was created -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 135051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135051&action=edit Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135051|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138475&action=edit Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- * space vs time? How do you decide which one is best? :D * _update_import_record_marc is no longer used * Missing tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139275&action=edit Bug 30779: Remove _update_import_record_marc and update tests This patch removes the now unused: _update_import_record_marc Additionally, as items are already present in import biblio we no longer need to embed them, so that parameter is removed In all cases, we were embedding, so we don't need a way to get without Tests updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
* space vs time? How do you decide which one is best? :D
Storage can be expanded, and space recovered. Time is not a renewable resource
* _update_import_record_marc is no longer used
removed
* Missing tests.
tests updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139275|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139285&action=edit Bug 30779: Remove _update_import_record_marc and update tests This patch removes the now unused: _update_import_record_marc Additionally, as items are already present in import biblio we no longer need to embed them, so that parameter is removed and the option removed from the sub and pod and everywhere it was used In all cases, we were embedding, so we don't need a way to get without Tests updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138475|0 |1 is obsolete| | Attachment #139285|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139287&action=edit Bug 30779: Do not update import marc after importing items We are stripping the marc item tags at import - we save them when not importing items, but strip when importing items I think we can save on writes by leaving them in the record. This also allows comparison to what was staged versus items created To test: 1 - Stage a marc record with items, but do not look for items 2 - Confirm the item tags remain in staged marc 3 - Import the record 4 - Confirm items are nto in imported marc record 5 - Stage the record again, but look for items 6 - Confirm the item tags are stipped from imported record 7 - Import and confirm imported record has no item tags 8 - Apply patch and repeat 1-5 9 - Confirm item tags remain in record 10 - Import and confirm item tags not in imported marc Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139288&action=edit Bug 30779: Remove _update_import_record_marc and update tests This patch removes the now unused: _update_import_record_marc Additionally, as items are already present in import biblio we no longer need to embed them, so that parameter is removed and the option removed from the sub and pod and everywhere it was used In all cases, we were embedding, so we don't need a way to get without Tests updated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38279 [Bug 38279] C4::ImportBatch::EmbedItemsInImportBiblio is not used -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org