[Bug 7351] New: ability to edit a range of holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Bug #: 7351 Summary: ability to edit a range of holidays Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools AssignedTo: christophe.croullebois@biblibre.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com The new feature that allows you to enter a range of holidays does not let you edit the range. So if you have a long range of dates and you messed up you have to edit them one by one. A way to edit/delete a range of dates would be nice. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6663 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-05 19:53:58 UTC --- Created attachment 7459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7459 Delete on a range of dates You have two options : Delete the single holidays on a range Delete the repeated holidays on a range The exceptions are not deleted. Need deep testing. Thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 19:38:07 UTC --- I was able to use this to delete a range of repeated yearly holidays but not repeated single holidays or repeated weekly holidays. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-08 12:57:17 UTC --- Hello Owen, right, about repeated weekly holidays it is deliberate, because you have max 7 days to edit/delete, I think it don't needs to be changed. However with the patch you must be able to delete either the singles holidays or the yearly repeated holidays... Have you checked the corresponding radio button ? I'll test and try to understand. thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-08 14:13:30 UTC --- Sry Owen I can't reproduce the bug. I'll join some snapshots, no idea why you can't delete a range of single holidays... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-08 14:22:55 UTC --- Created attachment 7502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7502 before -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-08 14:27:35 UTC --- Created attachment 7503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7503 single -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #7 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-08 14:30:11 UTC --- Created attachment 7504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7504 repeated -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #8 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-08 14:30:47 UTC --- Created attachment 7505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7505 after -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Owen Leonard <oleonard@myacpl.org> 2012-02-08 17:24:23 UTC --- (In reply to comment #3)
right, about repeated weekly holidays it is deliberate, because you have max 7 days to edit/delete, I think it don't needs to be changed.
I think I see what you mean: It's easy enough to select one of the repeated weekly events and delete the whole range from there. I think what I expected was that if the weekly event fell within the range I specified it would remove just those instances of the weekly event (i.e. create exceptions). I am similarly confused about how the "Delete the repeated holidays on a range" option works. Example: I specify a range of holidays repeating yearly (24 and 25 December, for instance). Then I select a range within that repeating pattern: 24 December 2015 through 25 December 2015 and choose "Delete the repeated holidays on a range." Doing so deletes the entire set of repeating yearly holidays defined in my original operation. Again, I expected it to delete only the dates I specified in the range I gave in the delete operation. I would be nice to get some other testers' input on that functionality to see if it's necessary to mitigate the confusion with some interface changes (labels, hints, whatever).
However with the patch you must be able to delete either the singles holidays or the yearly repeated holidays... Have you checked the corresponding radio button ?
I think I must have not had the correct radio button selected because it is working now. I'm putting this back to "needs signoff" because I'd like to get a second opinion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #10 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-09 10:46:10 UTC --- Hello Owen, yes it's the reason why I said "needs deep testing", I think this patch must have multiple advices. For the first point : the weekly repeatable days, I think we are ok, we can stay on what we have, day by day for deleting or exceptions. A part of the choices I have made was in regard of the technical structure and my lazy side. ;o) The patch can on a range of date either delete the single or repeated days, depending of the radio button selected. BUT if 'single' selected, and if in your range you have other kinds of holidays, only 'single' will be deleted, the same for 'repeated'... I have made the functions able to exit if there is some bad values, so if you don't put a value in 'to date:' for example or if the values are not in the scope, koha does nothing, I have chosen this option because you have the visual of dates on the calandar and if no action is done you can see it on calandar, and at my sense it's more ergonomic than some warnings messages with a clic to close them... But it's just my advice. On the other hand, you gave me an idea, I think I could add a third option to put exceptions on a range of date regarding the yearly repeated holidays... What do you think about ? thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2012-02-09 13:53:45 UTC --- (In reply to comment #10)
On the other hand, you gave me an idea, I think I could add a third option to put exceptions on a range of date regarding the yearly repeated holidays... What do you think about ?
What I'm not sure about is which is overall easier for the user. I think selecting a range within a yearly repeated holiday to create exceptions is a good feature. But then how does the user delete an *entire* range of repeated yearly holidays? Do they have to input the exact range? That sounds potentially difficult. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #12 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2012-02-09 16:26:07 UTC --- In fact Owen, in his actual state the patch is permissive, no obligations to put the exact range. eg: you have a range of yearly repeated holidays from 15 august to 31 august. You can : 1° select from 29 august to 4 september :result => only 29/30/31 august will be deleted..... 2° select from 25 july to 16 august :result => only 15/16 august will be deleted..... 3° you want the exact periode, then => select from 15 august to 31 august I wanted to make a light patch the first time, to edit the range, now we are further... But inside, all the job is done one day by one day, I don't change the DB structure, so we can delete one day of a range and so on. All the job for a range of 10 days is the same in the base, that you obtain with 10 edit/create... So I'll create an option to put exceptions on a range, and we'll see. Thx. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7459|0 |1 is obsolete| | Attachment #7502|0 |1 is obsolete| | Attachment #7503|0 |1 is obsolete| | Attachment #7504|0 |1 is obsolete| | Attachment #7505|0 |1 is obsolete| | --- Comment #13 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 8005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8005&action=edit the last patch with delete exceptions on a range I think I have finished the job. Thanks for testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #14 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tested on sand-box Something went wrong ! Applying: Bug 7351 : feature that allows to delete a range of dates Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Calendar.pm CONFLICT (content): Merge conflict in C4/Calendar.pm Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt Failed to merge in the changes. Patch failed at 0001 Bug 7351 : feature that allows to delete a range of dates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8005|0 |1 is obsolete| | --- Comment #15 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 8370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8370&action=edit patch finalized Corrected, it's ok now. Please retest. Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I try this : - Add Holidays on a range. - Add Holidays repeated yearly on a range I have the error : Software error: Missing right curly or square bracket at /home/koha/src/tools/newHolidays.pl line 149, at end of line syntax error at /home/koha/src/tools/newHolidays.pl line 149, at EOF Execution of /home/koha/src/tools/newHolidays.pl aborted due to compilation errors. For help, please send mail to the webmaster (webmaster@test4-sandbox), giving this error message and the time and date of the error. I try : "Generate an exception for this repeated holiday" : ok for the date where I have clic. I try : "Delete the repeated holidays on a range." nothing is done. (cf. attachement) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #17 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 8382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8382&action=edit Delete repeated holidays on a range -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #18 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Ok, thx, a stupid bug due to a lack of a semicolon.. But more, a bug on "Delete the exceptions on a range". So, new patch will follow soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8370|0 |1 is obsolete| | Attachment #8382|0 |1 is obsolete| | --- Comment #19 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 8506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8506&action=edit I hope the last one, patch finalised I hope no more bugs. Needs hard testing. thank you in advance -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8506|0 |1 is obsolete| | --- Comment #20 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 8585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8585&action=edit this patch is finalised correct a bug if no "from date" given and "Holidays on a range" selected. Now we don't have a page with "koha error", just the code do nothing and you see it on the calendar. Thx Leila for your tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Leila <leila.arkab@hotmail.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |leila.arkab@hotmail.fr --- Comment #21 from Leila <leila.arkab@hotmail.fr> --- Hi Tested again. We can apply holidays (1 day off, on a range), and undo this in different cases (Unique holiday, Holiday repeating weekly, Holiday repeating yearly, Holiday exception). I also tried to copy this to all libraries. OK. Thanks Christophe for this patch, and soon a new bugzilla for some little improvments. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8585|0 |1 is obsolete| | --- Comment #22 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 8964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8964&action=edit The patch finalized after cleaning code The same after cleaning the code. Could you sign off again Leila ? Thank you in advance. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 9075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9075&action=edit [SIGN OFF]Bug 7351 : feature that allows to delete a range of dates Four new options, one for single holidays, one for the repeatable holidays. One to create exceptions on a range of dates, one to delete exceptions in a range of dates. Note that the exceptions are not deleted if you delete a range of repeatable dates. But if you delete a range of single holidays the exeptions inside will be deleted. Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stephane.delaye@biblibre.co | |m --- Comment #24 from delaye <stephane.delaye@biblibre.com> --- test in a sandbox : it works we can create and delete holidays on a range. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #25 from Marc Véron <veron@veron.ch> --- *** Bug 7964 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comments: In general: I do not object to adding these options, but I am not convinced that we make life easier for the average user. When clicking a holiday, I now have 7 options instead of 3 options. Descriptions like "Deleting single holidays on a range" are not very intuitive. Since editing the holiday table is not a daily task, this may not need community discussions. I will set the status to Passed QA. I have no technical objections, but pass my "functional doubts" to the RM. Please note too: If you leave the To field empty, and choose for Deleting on a range, nothing happens. This behavior could be confusing for the user. IMO it still needs to be improved. Currently, we leave the user in a state wondering if something happened or not. A simple javascript check may already be sufficient. And a minor remark about a POD line: "Is the day month to make the date to delete." This description is not very clear. What is "day month"? IMO if you have three pars, day, month and year, you do not need to explain. While looking at the options, I detected some spelling issues too. Will add a patch for that. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 9621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9621&action=edit Patch for minor textual changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- Testing this patch, I get an ugly display (screenshot attached). I also tried with chrome, flushed the cache in case of a CSS problem, same problem -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 9691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9691&action=edit screenshot of ugly display -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #30 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hum, Paul, I have tested again, on a branch up to date, I have applyed my patch and the pages are ok... I join a snapshot Could anyone test ? Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #31 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 9869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9869&action=edit the page is ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #32 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- I have seen with Paul, maybe due to his hook git... Tested with two others PC. thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #33 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 9882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9882&action=edit this is an addon after M. de Rooy's patch As stated in patch comment, I have just put a space between the radio button and the text for the new lines.. And I have replaced tabulations by space. You must have applied before : "[SIGN OFF]Bug 7351 : feature that allows to delete a range of dates" "Patch for minor textual changes" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #34 from Paul Poulain <paul.poulain@biblibre.com> --- Sorry Christophe, but this patch make me crazy. Now it does not apply anymore. Could you please rebase and squash the 3 patches ? git rebase master git rebase -i HEAD~3 replace on line 2 and 3 "pick" by "squash" (ask me if needed) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #35 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Paul, too much time has passed, the calendar has changed, I have to rewrite code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9075|0 |1 is obsolete| | Attachment #9621|0 |1 is obsolete| | Attachment #9882|0 |1 is obsolete| | --- Comment #36 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 10862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10862&action=edit [SIGN OFF]Bug 7351 : feature that allows to delete a range of dates Ok Paul, now it must be ok. I hope... ;o) Just one patch, it's enough. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #37 from Mason James <mtj@kohaaloha.com> --- QA comment, passing QA all QA tests pass $ koha-qa.pl starting perlcritic-progressive tests... OK starting 'perl -c' syntax tests... OK starting xt/tt_valid.t tests... OK starting xt/author/vaild-template.t tests... OK patch applies clean to 60b6c187c46614431f109512c740a3bcf077f342 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #38 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #35)
Paul, too much time has passed, the calendar has changed, I have to rewrite code.
QA comment... hmm, i think we are still waiting for a sign-off for Christophe's rewrite here can someone do a quick test on it, and sign-off please setting status to 'needs sign-off' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #39 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- please sign-off ;o( thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |colin.campbell@ptfs-europe. | |com --- Comment #40 from Chris Cormack <chris@bigballofwax.co.nz> --- Colin, do you have any thoughts about this and Koha::Calendar? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #41 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Koha::Calendar left the entry and editing of Holidays to C4::Calendar basically reading the data only. The reason was that while the way the holidays were stored was not the best, if we tried to address that we'd also have to rewrite the interface doing the holiday create/update/delete. So I dont think this introduces any conflict. I'd still like one day (but not soon I expect) to have the whole logic overhauled and the user interface totally overhauled, possibly then Holiday could be separated out into its own object Holiday.pm. But until then.... In summary from a Koha::Calendar view I dont think this alters the interface it addresses. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #42 from Chris Cormack <chris@bigballofwax.co.nz> --- Cool, in that case im happy to sign off, will do that tonight. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10862|0 |1 is obsolete| | --- Comment #43 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11214&action=edit Bug 7351 : feature that allows to delete a range of dates Four new options, one for single holidays, one for the repeatable holidays. One to create exceptions on a range of dates, one to delete exceptions in a range of dates. Note that the exceptions are not deleted if you delete a range of repeatable dates. But if you delete a range of single holidays the exeptions inside will be deleted. Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #44 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Depending on tests, code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #45 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... trying to add a range of holiday, I get nothing. I can choose a range of dates, select "Holidays on a range", can click OK, but the holiday is not saved :((( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #46 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- hum Paul, this patch just works on the second feature about a range a date, the deletion. The first one I have made allows to create holidays on a range, and it is pushed. This one allows to delete on a range, so I don't understand, you says you can't add holidays on a range ? But it's not the purpose of this patch, anyway, I have just tested again few minutes ago, all is ok, even creating holidays on a range... Could you test again ? I see an other trouble with you there is some time => Christophe Croullebois 2012-06-01 09:45:21 UTC I have seen with Paul, maybe due to his hook git... Tested with two others PC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> --- Works like a charm. However, i've discovered some problems under plack, i'll open another bug for that. Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org