[Bug 29432] New: Item type deletion should test frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Bug ID: 29432 Summary: Item type deletion should test frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Actually the test to allow deleting an item type is : sub can_be_deleted { my ($self) = @_; my $nb_items = Koha::Items->search( { itype => $self->itemtype } )->count; my $nb_biblioitems = Koha::Biblioitems->search( { itemtype => $self->itemtype } )->count; return $nb_items + $nb_biblioitems == 0 ? 1 : 0; } But using item types on biblioitems.itemtype is not mandatory (for items.itype I do not know), so we should test if this DB column is configured in frameworks to use item types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am not sure I understand. In which cases it's a problem? You want to delete itemtype 'BOOK', 'BOOK' is used in biblioitems.itemtype but not using the 'itemtype' plugin and so you want to be able to delete the itemtype? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem here is something that we will encounter again and again. You can remove the plugin from the frameworks and use another list of authorised values for biblioitems.itemtype and I know some Biblibre libraries have done this, but I really believe that it's a terrible idea. Because on the other side we have hold features, article requests features, search and display features relying on this to be an actual item type. Note: I am speaking of features for item level itypes! We can change the check here... but I believe that we should not support this use case. It's harmful to the libraries locking them out of functionality and will keep having us add code and workarounds. ... and instead of changing the check you could use different codes to fix the issue locally in this case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK I close. We have a local fix : https://git.biblibre.com/biblibre/kohac/commit/c1a54004bff33174bde56c2ae3ada... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org