[Bug 16906] New: Add DataTables pagination and filter to top of saved SQL reports table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Bug ID: 16906 Summary: Add DataTables pagination and filter to top of saved SQL reports table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Right now the table of saved SQL reports has a DataTables toolbar at the bottom showing pagination options and the search field. I think it would be useful to have it at the top too, especially to make the search field more readily accessible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53329&action=edit Bug 16906 - Add DataTables pagination and filter to top of saved SQL reports table This patch adds a DataTables toolbar to the top of the saved SQL reports table so that pagination and filtering controls are at the top as well as the bottom. To test, apply the patch and go to Reports -> Saved reports. There should be controls at the top of the table of saved reports for setting number of results, pagination, and searching. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53329|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 53336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53336&action=edit Bug 16906 - Add DataTables pagination and filter to top of saved SQL reports table This patch adds a DataTables toolbar to the top of the saved SQL reports table so that pagination and filtering controls are at the top as well as the bottom. To test, apply the patch and go to Reports -> Saved reports. There should be controls at the top of the table of saved reports for setting number of results, pagination, and searching. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, any reasons not to remove the sDom definition to use the default one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
Owen, any reasons not to remove the sDom definition to use the default one?
No I guess not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53336|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53525&action=edit Bug 16906 - Add DataTables pagination and filter to top of saved SQL reports table This patch adds a DataTables toolbar to the top of the saved SQL reports table so that pagination and filtering controls are at the top as well as the bottom. To test, apply the patch and go to Reports -> Saved reports. There should be controls at the top of the table of saved reports for setting number of results, pagination, and searching. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53526&action=edit Bug 16906: Simply remove the sDom definition to use the default one Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org