[Bug 14999] New: Adding to basket orders from staged files mixes up the prices and quantities between different orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Bug ID: 14999 Summary: Adding to basket orders from staged files mixes up the prices and quantities between different orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: j.kylmala@gmail.com QA Contact: testopia@bugs.koha-community.org If one adds multiple item orders from a staged file to an basket the orders might change their values like price and item quantity between each other. This happens because in addorderiso2709.pl under the part "3rd step = import the records" there is a call to hasGetImportRecordsRange($import_batch_id) which gives some biblio info in some random order. And so this biblio info is used then like it would be in order and then the values mix up because of this. I have done a patch for this, and I'll put it here soon, so it will be more easier for you to understand! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #1 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43319&action=edit Bug 14999: Fetch the corresponding values for the specific biblio item This is just a fast way to fix this bug. If you figure out an better one, please send it here! Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43319|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43363&action=edit Bug 14999: Fetch the corresponding values for the specific biblio item UPDATE: I added a test plan, and this version also applies cleanly on the master branch. Test plan: 1. In acquisitions add orders to basket from a staged file. You need to add orders which when added doesn't show the right quantity/price in the basket (after it has been added). I succeeded in this by selecting order items from under different headings (in the page "Add orders from iso2709 file"). So this means that you would need to have a staged file with multiple sections in it. 2. Notice the problem with the wrong prices and quantities showing in the basket. 3. Apply this patch. 4. Remove those items you added to the basket and add them again and notice that they have now the corresponding values in them in the basket. 5. Look for anomalies. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43363|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43364&action=edit Bug 14999: Fetch the corresponding values for the specific biblio item Test plan: 1. In acquisitions add orders to basket from a staged file. You need to add orders which when added doesn't show the right quantity/price in the basket (after it has been added). I succeeded in this by selecting order items from under different headings (in the page "Add orders from iso2709 file"). So this means that you would need to have a staged file with multiple sections in it. 2. Notice the problem with the wrong prices and quantities showing in the basket. 3. Apply this patch. 4. Remove those items you added to the basket and add them again and notice that they have now the corresponding values in them in the basket. 5. Look for anomalies. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Lucio Moraes <lmoraes@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmoraes@catalyst.net.nz --- Comment #4 from Lucio Moraes <lmoraes@catalyst.net.nz> --- Hi Joonas, if you have a staged file to test, could you share with me? Thank you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Lucio Moraes from comment #4)
Hi Joonas, if you have a staged file to test, could you share with me? Thank you
Unfortunately I don't have one. And now I'm thinking if the patch I supplied here is obsolete because this might only apply for the https://github.com/KohaSuomi/kohasuomi version of Koha. I'll change the status to "In Discussion" for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org