[Bug 7680] New: Create a PatronDefaultView preference to control whether patron links go to circ or patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Priority: P5 - low Change sponsored?: --- Bug ID: 7680 CC: gmcharlt@gmail.com Assignee: oleonard@myacpl.org Blocks: 6670, 6905 Summary: Create a PatronDefaultView preference to control whether patron links go to circ or patron details QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: System Administration Product: Koha Bugs 6670 and 6905 ask that links to patron records take the user to the patron's circulation page instead of the patron detail page. A system preference should be created, PatronDefaultView, allowing the library to choose which view is preferred. Any link which is not explicitly intended for one or the other destination should be controlled by this preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8096&action=edit Bug 7680 - PatronDefaultView preference to control whether patron links go to circ or patron details The new include, patron-default-view.inc, outputs the *opening* half of the <a> so that individual templates can control whether to show full name, barcode, both, etc. Individual templates must often pass the "local" borrowernumber variable via the INCLUDE if the variable is not called "borrowernumber": [% INCLUDE 'patron-default-view.inc' borrowernumber = ITEM_DAT.borrowernumber %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8097&action=edit Bug 7680 [REVISED] PatronDefaultView preference to control whether patron links go to circ or patron details The new include, patron-default-view.inc, outputs the *opening* half of the <a> so that individual templates can control whether to show full name, barcode, both, etc. Individual templates must often pass the "local" borrowernumber variable via the INCLUDE if the variable is not called "borrowernumber": [% INCLUDE 'patron-default-view.inc' borrowernumber = ITEM_DAT.borrowernumber %] Revision: First patch didn't have the new include file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- A lot of pages are touched by this patch. Testers, FYI: catalogue/detail.tt catalogue/issuehistory.tt catalogue/moredetail.tt circ/branchoverdues.tt circ/branchtransfers.tt circ/circulation.tt circ/overdue.tt circ/returns.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt members/member-password.tt members/member.tt members/memberentrygen.tt members/moremember-print.tt members/moremember-receipt.tt members/moremember.tt members/update-child.tt offline_circ/list.tt offline_circ/process_koc.tt patroncards/members-search.tt reports/bor_issues_top.tt reserve/request.tt reviews/reviewswaiting.tt serials/viewalerts.tt suggestion/suggestion.tt tools/viewlog.tt virtualshelves/shelves.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8097|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8151&action=edit Bug 7680 [REVISED] PatronDefaultView preference to control whether patron links go to circ or patron details The new include, patron-default-view.inc, outputs the *opening* half of the <a> so that individual templates can control whether to show full name, barcode, both, etc. Individual templates must often pass the "local" borrowernumber variable via the INCLUDE if the variable is not called "borrowernumber": [% INCLUDE 'patron-default-view.inc' borrowernumber = ITEM_DAT.borrowernumber %] Revision: First patch didn't have the new include file. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- The two choices presented for this are 'circ' and 'details', but the default value installed is 'normal'. This does universally default to 'details', but when going to the syspref editor for the first time, 'circ' will be selected because it's first. Best to explicitly say 'circ' or 'details' instead of 'normal'. Also, are we sure that everyone one of these links should behave the same way? On the one hand, consistency is nice, but I envision a situation where certain links are used only by certain staff (who want it one way) and other links are used by other staff (who need the opposite functionality). Not going to mark as failed QA over these issues... but I will ask for someone to address these concerns in a reply before I mark this one as 'ready'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> ---
I envision a situation where certain links are used only by certain staff (who want it one way) and other links are used by other staff (who need the opposite functionality).
I don't think there's a perfect solution here. There's certainly the demand to change this on certain pages, so creating an option seems the best way to handle it. We can't do per-user preferences, so that's off the table pending work to make it possible. Better I think to be able to predict what you'll get. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- sorry, but the patch does not apply anymore because, probably, of some kohaDates plugins updates CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt They are not trivial, I don't want to do something wrong by fixing them myself. Other QA comment: calling the link patron-default-view.inc is not very intuitive, and I think that we will have problem when we will start building "views" for "objects". I'd prefer to have it called patron-default-link.inc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I would be happy to rebase this and make the requested corrections but is there enough consensus that this feature works as everyone thinks it should? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #8)
I would be happy to rebase this and make the requested corrections but is there enough consensus that this feature works as everyone thinks it should?
maybe you can switch the status to "in discussion", and start the discussion on mailing lists ? (to give my opinion = I have none yet) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca --- Comment #10 from marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi, anyone know where is the discussion of this system preference? Thanks Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Owen Leonard from comment #2)
The new include, patron-default-view.inc, outputs the *opening* half of the <a> so that individual templates can control whether to show full name, barcode, both, etc. In my opinion, it would be better if include contained the full anchor tag. Because templates are hard to read when they are not correct HTML. You could pass to include the content of the tag :
[% IF ( PatronDefaultView == 'circ' ) %] <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrowernumber %]">[% text %]</a> [% ELSE %] <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% text %]</a> [% END %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I'd be happy to pick this up again if others think it's a good idea (and I think it is). I'd like to hear more opinions though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Blocks| |9255 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #12)
I'd be happy to pick this up again if others think it's a good idea (and I think it is). I'd like to hear more opinions though.
I think it is a good idea too. Given that 4 bug reports are opened, it seems there is a real need here. see bug 6670, bug 6905 and bug 9255. Owen, I will be happy to test this patch if you rebase it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 6670 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 6905 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- It would be better if the content of the link (patron name) was sent to the include file, as a parameter. But it seems not to be easy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- I am still a candidate to SO or QA this patch if rebased :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #18 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi, I asked two years ago but this bug is still under discussion. Some news about it? Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- I'm still interested in working on this feature but don't have time for it at the moment. As far as I'm concerned it's not dead, FWIW. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org