[Bug 8728] New: t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Priority: P5 - low Change sponsored?: --- Bug ID: 8728 Assignee: gmcharlt@gmail.com Summary: t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve Severity: enhancement Classification: Unclassified OS: All Reporter: matted-34813@mypacks.net Hardware: All Status: NEW Version: unspecified Component: Test Suite Product: Koha The AddReserve routine had resdate and expdate added in between arguments (not appended) in 2009/2010ish and http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Reserves.pm;hb=... so we need to adjust the t/db_dependent/Reserve.t accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 --- Comment #1 from wajasu <matted-34813@mypacks.net> --- Created attachment 11983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11983&action=edit adjust-Reserves.t-test-for-resdate-and-expdate-and-t.patch This patch adds the resdate and expdate argument to the AddReserve test. I also adjusted it to create a bilio, and item for that biblio and delete them at the end of the test, so its not dependent on external test data. It gets rid of Illegal metric data warning from misaligned arguments. TestPlan: koha@biblio:~/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.03 usr 0.01 sys + 0.59 cusr 0.04 csys = 0.67 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Blocks| |5327 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11983|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12031&action=edit Bug 8728 : Adjust Reserves.t test for resdate and expdate and test setup/teardown Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works better now, creats biblio records, and cleans up after itself as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * 0 side-effect risk (unit test only) * koha-qa.pl irrelevent * looking at the code, nothing to say I can't test it on my sandbox because it's MAR21 and my demo is UNIMARC. Thus creating the test record badly fail: substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 498. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 500. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 500. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 502. Use of uninitialized value $enc in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 505. Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> Moffat, Steven at /usr/share/perl5/MARC/File/XML.pm line 505. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org