[Bug 5795] New: Missing ReservesControlBranch system pref in database installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Bug #: 5795 Summary: Missing ReservesControlBranch system pref in database installer Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Installation and upgrade (web-based installer) AssignedTo: henridamien@koha-fr.org ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Hie, "ReservesControlBranch" system preference is present in interface and udpatedatabase.pl but not in SQL installation scripts "sysprefs.sql". It's quite buggy in a fresh installation. Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_2 |master Assignee|henridamien@koha-fr.org |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bug is still valid for current master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9193&action=edit Bug 5795 - Missing ReservesControlBranch system pref in database installer sysprefs.sql file was missing ReservesControlBranch. To test: 1) Create a new installation and check sysprefs.sql loads correctly. 2) Check ReservesControlBranch shows up correctly in the sys pref editor. 3) Check sys pref can be edited and new value saves correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9193|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 9320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9320&action=edit Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer sysprefs.sql file was missing ReservesControlBranch. To test: 1) Create a new installation and check sysprefs.sql loads correctly. 2) Check ReservesControlBranch shows up correctly in the sys pref editor. 3) Check sys pref can be edited and new value saves correctly. Signed-off-by: Marc Veron <veron@veron.ch> - Line is added at the end of installer/data/mysql/sysprefs.sql - Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly. - Syspref shows up in Staff client -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7970 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@osslabs.biz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi@osslabs.biz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 --- Comment #4 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 9397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9397&action=edit Update the database as follow-up to Bug 5795 Update the database as follow-up to Bug 5795 If value is not exist it insert other wise update the existing value. To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; 3) It Show old result if value is present other wise it shows: +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9397|0 |1 is obsolete| | --- Comment #5 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 9451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9451&action=edit Update the database as follow-up to Bug 5795 If sys pref ReservesControlBranch has null then update the table to insert a ItemHomeLibrary as value To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary. +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@gmail.com> --- Can we define Bug 7970 has duplicate of this one ? No need to have the same patche in two bugs. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 --- Comment #7 from Amit Gupta <amit.gupta@osslabs.biz> --- Fridolyn SOMERS You can mark bug 7970 as a duplicate. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 --- Comment #8 from Amit Gupta <amit.gupta@osslabs.biz> --- *** Bug 7970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9320|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9541&action=edit Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer sysprefs.sql file was missing ReservesControlBranch. To test: 1) Create a new installation and check sysprefs.sql loads correctly. 2) Check ReservesControlBranch shows up correctly in the sys pref editor. 3) Check sys pref can be edited and new value saves correctly. Signed-off-by: Marc Veron <veron@veron.ch> - Line is added at the end of installer/data/mysql/sysprefs.sql - Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly. - Syspref shows up in Staff client Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> - Fixed merge conflict -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9451|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9542&action=edit Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has null then update the table to insert a ItemHomeLibrary as value To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary. +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | ItemHomeLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments, A little comment: First patch (syspref.sql) insert the syspref with the "PatronLibrary" default value whereas updatedatabase insert with "ItemHomeLibrary". Marking as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 --- Comment #12 from Amit Gupta <amit.gupta@osslabs.biz> --- PatronLibrary as default value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9542|0 |1 is obsolete| | --- Comment #13 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 9695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9695&action=edit Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has null then update the table to insert a PatronLibrary as value Bug 5795 Update the database as follow-up If sys pref ReservesControlBranch has null then update the table to insert a PatronLibrary as value To Test: 1) Go to mysql use koha database 2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary. +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | variable | value | options | explanation | type | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ | ReservesControlBranch | PatronLibrary | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice | +-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+ PatronLibrary as default value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Previous patch is already signed off by Chris -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Last patch modify the default value for the syspref. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5795 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org