[Bug 29301] New: Display error with serials search flatpickr when searching Mana
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Bug ID: 29301 Summary: Display error with serials search flatpickr when searching Mana Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 28958 Blocks: 29239 In Serials there is an option to search Mana outside the context of adding a subscription: The "Search on Mana" link in the sidebar. This form looks wrong because some inputs are hidden in a way that doesn't hide all Flatpickr-generated elements. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958 [Bug 28958] Use Flatpickr on serials pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29299 [Bug 29299] Reindent serials search template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126665&action=edit Bug 29301: Display error with serials search flatpickr when searching Mana This patch changes the way certain serials search fields are hidden when a standalone search of Mana is being performed (from the "Search on Mana" link). Instead of targeting specific labels and inputs to hide we can hide list items by class. Unrelated: This patch updates the page heading so that it is different depending on whether you're searching Koha subscriptions or Mana subscriptions. To test, apply the patch and enable Mana. - Go to Serials -> Advanced search (in the search header). - The search form should include all fields, including call number, vendor, library, location, and "Expires before." - Click "Search on Mana" in the sidebar. - This page should have the heading "Mana subscriptions search," and there should only be three fields visible: ISSN, Title, and Publisher. - When you perform a Mana search which returns results the page should have the heading "Mana subscriptions (X found). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126665|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126676&action=edit Bug 29301: Display error with serials search flatpickr when searching Mana This patch changes the way certain serials search fields are hidden when a standalone search of Mana is being performed (from the "Search on Mana" link). Instead of targeting specific labels and inputs to hide we can hide list items by class. Unrelated: This patch updates the page heading so that it is different depending on whether you're searching Koha subscriptions or Mana subscriptions. To test, apply the patch and enable Mana. - Go to Serials -> Advanced search (in the search header). - The search form should include all fields, including call number, vendor, library, location, and "Expires before." - Click "Search on Mana" in the sidebar. - This page should have the heading "Mana subscriptions search," and there should only be three fields visible: ISSN, Title, and Publisher. - When you perform a Mana search which returns results the page should have the heading "Mana subscriptions (X found). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126676|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127015&action=edit Bug 29301: Display error with serials search flatpickr when searching Mana This patch changes the way certain serials search fields are hidden when a standalone search of Mana is being performed (from the "Search on Mana" link). Instead of targeting specific labels and inputs to hide we can hide list items by class. Unrelated: This patch updates the page heading so that it is different depending on whether you're searching Koha subscriptions or Mana subscriptions. To test, apply the patch and enable Mana. - Go to Serials -> Advanced search (in the search header). - The search form should include all fields, including call number, vendor, library, location, and "Expires before." - Click "Search on Mana" in the sidebar. - This page should have the heading "Mana subscriptions search," and there should only be three fields visible: ISSN, Title, and Publisher. - When you perform a Mana search which returns results the page should have the heading "Mana subscriptions (X found). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, QA script passes.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Bug 29301 depends on bug 29299, which changed state. Bug 29299 Summary: Reindent serials search template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29299 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29301 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org