http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20753|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20882&action=edit [PASSED QA] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl When using UNIMARC XSLT for OPAC detail page, if record has a 856$u its content is displayed as a link. The syspref OPACURLOpenInNewWindow adds the option of opening in a new window (attribute target="_blank"). 856$u is also used in UNIMARC results XSLT but the use of OPACURLOpenInNewWindow syspref is missing. It exists for MARC21. This patch adds the use of OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl. Test plan : - In a UNIMARC catalog, enable XSLT for OPAC results page - Create a record with a link in 856$u and set second indicator to 0 - Set OPACURLOpenInNewWindow syspref on - At OPAC, perform a search that contains the record => You should see the link : "Click here to access online" - click on it => You shoud get to a new window (or tab depending on your browser configuration) - Set OPACURLOpenInNewWindow syspref off - re-perform the search - click on the link => You shoud stay in same window Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors Tested following plan after applying patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT change only, works as described. To test: Catalog 856$u and $a, 2nd indicator = 0. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Do you know if the changes were made too in the new bootstrap opac ? Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Fridolyn SOMERS from comment #6)

(In reply to mathieu saby from comment #5)

...

Do you know if the changes were made too in the new bootstrap opac ? No they didn't. Must I make a follow-up ?

We have now 3 themes for opac. That's a lot ;-) I did not test boostrap opac. Does the xslt have something "special", or are they a mere copy of the xslt of old opac? If so, I suppose all changes made to old xslt should be copied to bootsrap xslt too. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch has been pushed to 3.8.x, and will be in 3.08.20. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes.