[Bug 16314] New: Hover text on upload file icon plugin incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Bug ID: 16314 Summary: Hover text on upload file icon plugin incorrect Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The hover text for the upload file icon (commonly used with the 856u) says "Tag editor" when it should say something like "Select uploaded file." In truth, I think the icon should be different for this, as it's not really even the same sort of animal as the usual tag editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hover text on upload file |Show upload link for upload |icon plugin incorrect |plugin in basic MARC editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106784&action=edit Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106784|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 109561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109561&action=edit Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109561|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109792&action=edit Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, works as expected, no regressions found and passes QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | Severity|minor |enhancement CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 20.05.x for 20.05.04 (comment for lucas) enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I forgot to update the .css file, it's done now! commit d9815855bd6e442857fdae0c48335f9fe5d17507 Bug 16314: Compiled CSS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org