[Bug 22440] New: ILL API response objects inconsistent with other endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Bug ID: 22440 Summary: ILL API response objects inconsistent with other endpoints Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Target Milestone: --- The response object returned from the /api/vi/illrequest GET route isn't consistent with response objects supplied by other routes, such as the patrons route. We have an RFC for this route here: https://wiki.koha-community.org/wiki/Illrequests_endpoint_RFC Josef has made some initial recommendations on what the properties should be named to make them consistent with other routes. We could do with expanding this RFC to make it complete, including a spec on how object embedding should be done since, to date, this is the only route that does this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 CC| |josef.moravec@gmail.com Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Illrequests_endpo | |int_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Further suggestions from Josef to bring this endpoint into line. We should follow the convention illustrated here: https://github.com/Koha-Community/Koha/blob/master/Koha/REST/V1/Library.pm#L... This automagically looks at the parameters passed in the request and, if they match parameters described in the OpenAPI spec and, if they match, uses their values as filters. The _to_api & _to_model methods will allow us to carry out the property name consistency described in the bug description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Bug 22440 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032 [Bug 29032] ILL route unusable (slow) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30277 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28641 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22714 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Bug 22440 depends on bug 29032, which changed state. Bug 29032 Summary: ILL route unusable (slow) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 30277 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 [Bug 33544] Squash some ILL fields to alleviate request table overflow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 [Bug 33685] We should display both backend and local status for ILL loan requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150715&action=edit Bug 22440: Add Koha::Illrequests->filter_by_visible This patch introduces a method for filtering out requests that match the statuses specified on the *ILLHiddenRequestStatuses* system preference. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Illrequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150716&action=edit Bug 22440: Add missing foreign key Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150717&action=edit Bug 22440: Add standard accessors for later usage Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150718&action=edit Bug 22440: Add GET /ill_requests Co-authored-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150719&action=edit Bug 22440: New ILL requests table Use kohaTable requesting the REST api instead of the old KohaTable Co-authored-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150720&action=edit Bug 22440: ILL API changes * Add GET /illbackends/{id}/statuses * Change API route to ill/requests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150721&action=edit Bug 22440: Tests Updated API tests Co-authored-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150722&action=edit Bug 22440: Move backend statuses api endpoint Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150723&action=edit Bug 22440: Schema Update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This has had significant testing in house at PTFS-E and was worked on collaboratively by Tomas and Pedro (with a little interruption from myself a few times) We all agreed to go PQA given the eyes's it's had on :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 [Bug 33545] Adding faceting to API result sets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 22714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL API response objects |Improve ILL page |inconsistent with other |performance by moving to |endpoints |server side filtering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31705 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 150788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150788&action=edit Bug 22440: (follow-up) Nothing is forever This patch picks (yet) another class for testing purposes. The class needs to not implement to_api() and to_api_mapping(). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 150789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150789&action=edit Bug 22440: (follow-up) Fix existing tests As we are introducing a FK for illrequests.biblio_id, TestBuilder is generating a linked biblio, and so tests expecting undef are failing. This fixes it by explicitly setting biblio_id => undef on creating the request. The patch also cleans the area a bit, removing a redundant and fragile test as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 [Bug 26635] Expand coded values in REST API call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 [Bug 33834] api/v1/ill_requests.t fails randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33874 [Bug 33874] ILL Table - Pressing a column header to sort causes left-side filter values to be applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I am not so happy about the FK change hidden/sneaked in with this bug. Especially since it's now without documentation/warning to users and can create data loss. If you don't store all information also in ILL request attributes it will be hard to determine what has been ordered for making acq decisions and creating reports. Also: there already was as specific bug for this change, stuck in discussion for these reasons: bug 21983 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
And IRC: Joubu> tcohen: see https://tree.taiga.io/project/koha-ils/task/117 Joubu> tcohen: installer/data/mysql/db_revs/221200026.pl Joubu> it must be *unless* fk exists! Joubu> there is also a typo in the description endopoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Fixed in 23.05 and 23.11. Please backport the fix for 22.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #19)
Hm, I am not so happy about the FK change hidden/sneaked in with this bug. Especially since it's now without documentation/warning to users and can create data loss.
If you don't store all information also in ILL request attributes it will be hard to determine what has been ordered for making acq decisions and creating reports.
Also: there already was as specific bug for this change, stuck in discussion for these reasons: bug 21983
I'd have loved to at least get a comment/reaction. The fix mentioned seems to be to enforce the change I marked as critical. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #22)
(In reply to Katrin Fischer from comment #19)
Hm, I am not so happy about the FK change hidden/sneaked in with this bug. Especially since it's now without documentation/warning to users and can create data loss.
If you don't store all information also in ILL request attributes it will be hard to determine what has been ordered for making acq decisions and creating reports.
Also: there already was as specific bug for this change, stuck in discussion for these reasons: bug 21983
I'd have loved to at least get a comment/reaction. The fix mentioned seems to be to enforce the change I marked as critical.
Also, if you really want to do this, because it needs to be done: what's with the old ill_requests? It caused bug 33873. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #23)
(In reply to Katrin Fischer from comment #22)
(In reply to Katrin Fischer from comment #19)
Hm, I am not so happy about the FK change hidden/sneaked in with this bug. Especially since it's now without documentation/warning to users and can create data loss.
If you don't store all information also in ILL request attributes it will be hard to determine what has been ordered for making acq decisions and creating reports.
Also: there already was as specific bug for this change, stuck in discussion for these reasons: bug 21983
I'd have loved to at least get a comment/reaction. The fix mentioned seems to be to enforce the change I marked as critical.
Also, if you really want to do this, because it needs to be done: what's with the old ill_requests? It caused bug 33873.
Should we do the same we did for orderlines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #24)
(In reply to Katrin Fischer from comment #23)
(In reply to Katrin Fischer from comment #22)
(In reply to Katrin Fischer from comment #19)
Hm, I am not so happy about the FK change hidden/sneaked in with this bug. Especially since it's now without documentation/warning to users and can create data loss.
If you don't store all information also in ILL request attributes it will be hard to determine what has been ordered for making acq decisions and creating reports.
Also: there already was as specific bug for this change, stuck in discussion for these reasons: bug 21983
I'd have loved to at least get a comment/reaction. The fix mentioned seems to be to enforce the change I marked as critical.
Also, if you really want to do this, because it needs to be done: what's with the old ill_requests? It caused bug 33873.
Should we do the same we did for orderlines?
A database table has the option to use COALESCE, so that might be an option. We could also then shift the existing data. I am not sure what the technical requirement for the FK was, so can't tell if removing it again might be a valid option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 [Bug 34058] ILL - Left filters not considering all terms in input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34130 [Bug 34130] ILL requests table won't load if request_placed date is null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is not used, right? + if ( col.datatype == 'date' ) { + let rfc3339 = $date_to_rfc3339(value); + if ( rfc3339 != 'Invalid Date' ) { + built_value = rfc3339; + } + } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 [Bug 34226] Format dates from DT filters before querying the REST API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34223 [Bug 34223] ILL status filter does not load immediately after selecting a backend filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34246 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34283 [Bug 34283] ILL table left filters ignoring library prefix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 [Bug 36565] Fix API docs inconsistencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #28 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 23557 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org