https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48253&action=edit Bug 15867 - Move MARC modification templates JavaScript into separate file The JavaScript embedded in the MARC modification templates template is not dependent on template processing to such an extent that it can't be safely moved to a separate file. This patch does so, adding definition of a some translatable strings to the template. Other minor changes: A couple of JSHint warnings corrected, a couple of missing semicolons added to template markup. To test, apply the patch and go to Tools -> MARC modification templates - Confirm that The add/update form works normally with various actions (Add/update,Delete,Move, etc.). - Confirm that template switching works correctly. - Confirm that template deletion confirmation works correctly. - Confirm that cancelling an edit works correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #2)

JSHint give me one error:

koha-tmpl/intranet-tmpl/prog/en/js/marc_modification_templates.js: line 182, col 14, 'i' is already defined.

I think that is a case where the warning can be ignored, since "i" is only being used in the for loop. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48313|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48461&action=edit Bug 15867: Move MARC modification templates JavaScript into separate file The JavaScript embedded in the MARC modification templates template is not dependent on template processing to such an extent that it can't be safely moved to a separate file. This patch does so, adding definition of a some translatable strings to the template. Other minor changes: A couple of JSHint warnings corrected, a couple of missing semicolons added to template markup. To test, apply the patch and go to Tools -> MARC modification templates - Confirm that The add/update form works normally with various actions (Add/update,Delete,Move, etc.). - Confirm that template switching works correctly. - Confirm that template deletion confirmation works correctly. - Confirm that cancelling an edit works correctly Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Severity|minor |enhancement --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- severity changed to enhancement -- You are receiving this mail because: You are watching all bug changes.