[Bug 27774] New: Always remove hyphens from ISBN when cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Bug ID: 27774 Summary: Always remove hyphens from ISBN when cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6590 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Sort of a renew of Bug 6590 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 117277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117277&action=edit Bug 27774: Always remove hyphens from ISBN when cataloging Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. We may after this remove other codes that remove hyphens before cataloguing a biblio record. Test plan : 1) Create a new record with an ISBN with hyphen, ie 978-0008376109 2) Save 3) Export to MARCXML and see ISBN has hyphen 4) Look into database : select isbn from biblioitems where bilionumber=xxx 5) Check you see ISBN without hyphen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117277|0 |1 is obsolete| | --- Comment #3 from Frank Hansen <frank.hansen@ub.lu.se> --- Created attachment 117329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117329&action=edit Bug 27774: Always remove hyphens from ISBN when cataloging Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. We may after this remove other codes that remove hyphens before cataloguing a biblio record. Test plan : 1) Create a new record with an ISBN with hyphen, ie 978-0008376109 2) Save 3) Export to MARCXML and see ISBN has hyphen 4) Look into database : select isbn from biblioitems where bilionumber=xxx 5) Check you see ISBN without hyphen Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117329|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 119413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119413&action=edit Bug 27774: Always remove hyphens from ISBN when cataloging Actually hyphens are removed from ISBN when using acquisition or z3950 cataloguing or with bulkmarcimport. I propose to add this behavior in TransformMarcToKoha() so MARC data is unchanged, but biblioitems.isbn is without hyphens. This can be used if search using SQL and in reports. We may after this remove other codes that remove hyphens before cataloguing a biblio record. Test plan : 1) Create a new record with an ISBN with hyphen, ie 978-0008376109 2) Save 3) Export to MARCXML and see ISBN has hyphen 4) Look into database : select isbn from biblioitems where bilionumber=xxx 5) Check you see ISBN without hyphen Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 119414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119414&action=edit Bug 27774: Add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119414|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119452&action=edit Bug 27774: Add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> JD amended patch: s/all three mappings/all mappings/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
From bug 6590 it seems that people didn't agree on removing hyphens for ISBNs
Bug 6590 comment 15:
In UNIMARC, ISBN field is supposed to contain ISBN as written on the book cover. ISBN without hyphens can be stored in EAN (073) field.
Why did you open a separate bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Piouf I don't remember. I'm OK if this one is closed as duplicate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 6590 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org