http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42904|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42918&action=edit [SIGNED-OFF] Bug 14906: Koha::Logger - handle permission issues Koha::Logger should log in the regular log files if the paths are not correctly set (does not exist, no permission to write, etc.). Test plan: Set a path without write permission for the intranet in the log4perl configuration file. The one for opac should be correct. Try to write 1 line in the OPAC file. Without this patch, nothing is logged, and nothing is warned in the regular Koha log file. With this patch, the line in the OPAC log file will be appened and the Koha log file will have a line with a permission issue. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- First chmod your opac logfile to 400. Second, try this test please: use Koha::Logger; my $logger = Koha::Logger->get({ interface => 'opac' }); $logger->warn('L4'); Without this patch, you will have no warning since the log is not writable. With your patch, the program will crash (on the following call on line 132 after calling _check_conf): Log::Log4perl->init_once($conf); The intention of the code in Logger.pm was just to prevent such a crash. This patch reintroduces it. Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I get Logger configuration error - Wrong permission for file /home/koha/var/log/opac-error.log at t.pl line 289. Can't open /home/koha/var/log/opac-error.log (Permission denied) at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 124. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)

Forget last comment.

Marcel, what do you suggest?

If one of those two logfiles (opac, intranet) is not writable, log4perl will crash nicely. The goal was to prevent such a crash. So I would suggest to add the warnings about the unwritable logfile and still return undef. So do not call log4perl and no additional log message. Note that this situation should be quite unusual. Probably both files are writable or both are not. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver@bywatersolutions.co | |m --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- May I ask why this was resolved invalid? It's a rather surprising silent failure that I had to find with a debugger, and anything besides silence would be preferable. Yes, this is unlikely in production, but it would still be nice to fix. -- You are receiving this mail because: You are watching all bug changes.