[Bug 30411] New: Add separate shelving location column to Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Bug ID: 30411 Summary: Add separate shelving location column to Holds Queue Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would be useful, especially with Bug 29015, for shelving location to be its own column in the Holds Queue. This would allow for more flexibility in how libraries view and sort their queues, especially if it's configurable in Table settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29015 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132659&action=edit Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Rachael <rachael.laritz@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Rachael <rachael.laritz@inlibro.com> --- patch does not apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #3 from Juliet Heltibridle <jheltibridle@rcplib.org> --- *** Bug 33889 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132659|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168217&action=edit Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- In my test the wrong column is getting hidden. It looks like the "columnname: location" in columns_settings.yml is out of sequence? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168217|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168235&action=edit Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #5)
In my test the wrong column is getting hidden. It looks like the "columnname: location" in columns_settings.yml is out of sequence?
Oops, thanks for testing. Revised and reset to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168235|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168238&action=edit Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168238|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168244&action=edit Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add separate shelving |Add separate shelving |location column to Holds |location column to holds |Queue |queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me.
I'm happy to file a follow-up if you would like to follow a more standard sequence. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think orienting ourselves at the items/holdings table might be an idea. Maybe if we can get one more vote for this to be one way or the other :) (and just heading out for the day too) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |Adds shelving location as release notes| |its own column in the holds | |queue. This makes it easier | |to sort the holds queue by | |shelving location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rachael.laritz@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41126 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org