[Bug 3130] New: IE7: Javascript warning on Holds ratios to calculate if there are no hold ratios over the threshold
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3130 Summary: IE7: Javascript warning on Holds ratios to calculate if there are no hold ratios over the threshold Product: Koha Version: rel_3_0 Platform: PC URL: http://staff-dfs4.dev.kohalibrary.com/cgi- bin/koha/circ/reserveratios.pl OS/Version: All Status: NEW Severity: minor Priority: P3 Component: Browser compatibility AssignedTo: joe.atzberger@liblime.com ReportedBy: daniel.sweeney@liblime.com CC: oleonard@myacpl.org, galen.charlton@liblime.com Estimated Hours: 0.0 When the admin enters the Holds Ratios form, if there are no holds in the system that meet the selected criteria, IE7 raises a javascript error: line 3, char 6697 error: 'undefined' is null or not an object If you ignore the warning, the page works otherwise. The warning does not come up if any holds meet the criteria on the form. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3130 Joe Atzberger <joe.atzberger@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Joe Atzberger <joe.atzberger@liblime.com> 2009-04-28 20:13:50 --- This bug is reported by FF/Firebug also. The error appears to be internal to jquery.tablesorter.min.js. tablesorter reports an error that breaks the minified version before 2.0.3: http://tablesorter.com/changelog The date suggest that we have the working version, but I want to DL and diff against the current one. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3130 --- Comment #2 from Joe Atzberger <joe.atzberger@liblime.com> 2009-04-28 20:29:28 --- FYI, Firebug error is "parsers is undefined", but w/ the minified jquery file, the line number (2) is meaningless. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3130 Joe Atzberger <joe.atzberger@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |PATCH-Sent --- Comment #3 from Joe Atzberger <joe.atzberger@liblime.com> 2009-04-28 23:28:08 --- Confirmed minified version is current. Attempting to debug w/ non-minified version shows same error "parsers is undefined" from line 483. That's the inner line from: function getCachedSortType(parsers,i) { return parsers[i].type; }; I think the problem is that the table is empty/missing initially. This script has some other errors that need to be cleaned up too. Specifically, it is passing more holds than necessary to the template and letting a template conditional inside the loop control whether to display or not. That doesn't make sense, and it forces the table to be displayed even when all rows FAIL the conditional. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3130 --- Comment #4 from Galen Charlton <galen.charlton@liblime.com> 2009-04-29 12:44:58 --- Patch pushed. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3130 daniel sweeney <daniel.sweeney@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from daniel sweeney <daniel.sweeney@liblime.com> 2009-04-29 17:58:26 --- Confirmed fixed. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠liblime.com